From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbdLFRix (ORCPT ); Wed, 6 Dec 2017 12:38:53 -0500 Received: from g2t1383g.austin.hpe.com ([15.233.16.89]:53651 "EHLO g2t1383g.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751544AbdLFRiu (ORCPT ); Wed, 6 Dec 2017 12:38:50 -0500 Subject: Re: [PATCH] x86/platform/UV: make functions uv_handle_nmi and uv_nmi_setup_common static To: Colin King , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , "maintainer:X86" , Russ Anderson , "travis @ sgi . com" Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171206170828.23524-1-colin.king@canonical.com> From: Mike Travis Message-ID: Date: Wed, 6 Dec 2017 09:38:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171206170828.23524-1-colin.king@canonical.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I know you've already changed it but the UV changes look fine, so ACK for that. Thanks. On 12/6/2017 9:08 AM, Colin King wrote: > From: Colin Ian King > > Functions uv_handle_nmi and uv_nmi_setup_common are local to the > source and do not need to be in global scope, so make them static. > > Cleans up sparse warnings: > symbol 'uv_handle_nmi' was not declared. Should it be static? > symbol 'uv_nmi_setup_common' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > arch/x86/platform/uv/uv_nmi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/platform/uv/uv_nmi.c b/arch/x86/platform/uv/uv_nmi.c > index c34bd8233f7c..5f64f30873e2 100644 > --- a/arch/x86/platform/uv/uv_nmi.c > +++ b/arch/x86/platform/uv/uv_nmi.c > @@ -905,7 +905,7 @@ static inline void uv_call_kgdb_kdb(int cpu, struct pt_regs *regs, int master) > /* > * UV NMI handler > */ > -int uv_handle_nmi(unsigned int reason, struct pt_regs *regs) > +static int uv_handle_nmi(unsigned int reason, struct pt_regs *regs) > { > struct uv_hub_nmi_s *hub_nmi = uv_hub_nmi; > int cpu = smp_processor_id(); > @@ -1013,7 +1013,7 @@ void uv_nmi_init(void) > } > > /* Setup HUB NMI info */ > -void __init uv_nmi_setup_common(bool hubbed) > +static void __init uv_nmi_setup_common(bool hubbed) > { > int size = sizeof(void *) * (1 << NODES_SHIFT); > int cpu; >