From: "luobin (L)" <luobin9@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <luoxianjun@huawei.com>,
<yin.yinshi@huawei.com>, <cloud.wangxiaoyun@huawei.com>
Subject: Re: [PATCH net-next v1 5/5] hinic: add support to get eeprom information
Date: Tue, 23 Jun 2020 14:48:35 +0800 [thread overview]
Message-ID: <c980638a-2229-7ea4-79fd-2f19d70d40cf@huawei.com> (raw)
In-Reply-To: <20200622151520.79ab2af9@kicinski-fedora-PC1C0HJN>
On 2020/6/23 6:15, Jakub Kicinski wrote:
> On Sat, 20 Jun 2020 17:42:58 +0800 Luo bin wrote:
>> diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port.h b/drivers/net/ethernet/huawei/hinic/hinic_port.h
>> index 5c916875f295..0d0354241345 100644
>> --- a/drivers/net/ethernet/huawei/hinic/hinic_port.h
>> +++ b/drivers/net/ethernet/huawei/hinic/hinic_port.h
>> @@ -677,6 +677,37 @@ struct hinic_led_info {
>> u8 reset;
>> };
>>
>> +#define MODULE_TYPE_SFP 0x3
>> +#define MODULE_TYPE_QSFP28 0x11
>> +#define MODULE_TYPE_QSFP 0x0C
>> +#define MODULE_TYPE_QSFP_PLUS 0x0D
>> +
>> +#define STD_SFP_INFO_MAX_SIZE 640
>
> Please use the existing defines, e.g. from #include <linux/sfp.h>
> there is no need for every driver to redefine those constants.
> .
>
Will fix. Thanks for your review.
prev parent reply other threads:[~2020-06-23 6:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-20 9:42 [PATCH net-next v1 0/5] hinic: add some ethtool ops support Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 1/5] hinic: add support to set and get pause params Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 2/5] hinic: add support to set and get irq coalesce Luo bin
2020-06-22 22:07 ` Jakub Kicinski
2020-06-23 6:40 ` luobin (L)
2020-06-22 22:08 ` Jakub Kicinski
2020-06-23 6:41 ` luobin (L)
2020-06-20 9:42 ` [PATCH net-next v1 3/5] hinic: add self test support Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 4/5] hinic: add support to identify physical device Luo bin
2020-06-20 9:42 ` [PATCH net-next v1 5/5] hinic: add support to get eeprom information Luo bin
2020-06-20 16:00 ` Andrew Lunn
2020-06-22 2:05 ` luobin (L)
2020-06-22 22:15 ` Jakub Kicinski
2020-06-23 6:48 ` luobin (L) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c980638a-2229-7ea4-79fd-2f19d70d40cf@huawei.com \
--to=luobin9@huawei.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoxianjun@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=yin.yinshi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®