From: Mukesh Ojha <mojha@codeaurora.org>
To: Colin King <colin.king@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf test: fix spelling mistake "leadking" -> "leaking"
Date: Wed, 17 Apr 2019 16:37:24 +0530 [thread overview]
Message-ID: <c9808cb2-7025-2b7a-f311-c69469fc1341@codeaurora.org> (raw)
In-Reply-To: <20190417105539.5902-1-colin.king@canonical.com>
On 4/17/2019 4:25 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are a couple of spelling mistakes in test assert messages. Fix them.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Well, how are you shooting these mistakes one after the other?
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> tools/perf/tests/dso-data.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/tests/dso-data.c b/tools/perf/tests/dso-data.c
> index 7f6c52021e41..946ab4b63acd 100644
> --- a/tools/perf/tests/dso-data.c
> +++ b/tools/perf/tests/dso-data.c
> @@ -304,7 +304,7 @@ int test__dso_data_cache(struct test *test __maybe_unused, int subtest __maybe_u
> /* Make sure we did not leak any file descriptor. */
> nr_end = open_files_cnt();
> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
> return 0;
> }
>
> @@ -380,6 +380,6 @@ int test__dso_data_reopen(struct test *test __maybe_unused, int subtest __maybe_
> /* Make sure we did not leak any file descriptor. */
> nr_end = open_files_cnt();
> pr_debug("nr start %ld, nr stop %ld\n", nr, nr_end);
> - TEST_ASSERT_VAL("failed leadking files", nr == nr_end);
> + TEST_ASSERT_VAL("failed leaking files", nr == nr_end);
> return 0;
> }
next prev parent reply other threads:[~2019-04-17 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 10:55 Colin King
2019-04-17 11:07 ` Mukesh Ojha [this message]
2019-04-17 11:09 ` Colin Ian King
2019-04-17 17:37 ` Arnaldo Carvalho de Melo
2019-05-18 8:47 ` [tip:perf/core] perf test: Fix " tip-bot for Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9808cb2-7025-2b7a-f311-c69469fc1341@codeaurora.org \
--to=mojha@codeaurora.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=colin.king@canonical.com \
--cc=jolsa@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®