From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392AbdEJBZi (ORCPT ); Tue, 9 May 2017 21:25:38 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:55891 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdEJBZg (ORCPT ); Tue, 9 May 2017 21:25:36 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: kever.yang@rock-chips.com X-FST-TO: roger.chen@rock-chips.com X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: kever.yang@rock-chips.com X-UNIQUE-TAG: <8dd7492b597be9e13bb1be478aaf5cd9> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 3/4] ARM: dts: rockchip: use pin constants to describe IO in pinctrl To: Heiko Stuebner References: <1491981044-24635-1-git-send-email-kever.yang@rock-chips.com> <1491981044-24635-3-git-send-email-kever.yang@rock-chips.com> <3966386.YQGqDXjHSp@phil> Cc: linux-rockchip@lists.infradead.org, Rob Herring , Shawn Lin , Huibin Hong , Elaine Zhang , Catalin Marinas , David Wu , Brian Norris , Jaehoon Chung , Douglas Anderson , Will Deacon , Matthias Brugger , devicetree@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Jianqun Xu , linux-kernel@vger.kernel.org, Andy Yan , Caesar Wang , Mark Rutland , Roger Chen From: Kever Yang Message-ID: Date: Wed, 10 May 2017 09:25:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3966386.YQGqDXjHSp@phil> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Heiko, On 05/10/2017 05:43 AM, Heiko Stuebner wrote: > Am Mittwoch, 12. April 2017, 15:10:43 CEST schrieb Kever Yang: >> Use command below to replace the IO naming in pinctrl: >> sed -i -e 's/ 31 RK_FUNC_/ RK_PD7 RK_FUNC_/' arch/arm/boot/dts/rk* >> sed -i -e 's/ 0 RK_FUNC_/ RK_PA0 RK_FUNC_/' >> arch/arm64/boot/dts/rockchip/* >> >> Signed-off-by: Kever Yang > I'm not sure, if we really want to mass-convert each and every pin. > All pins in use right now seem to be working and it hides other > history/blame for these entries. Do you mean you want to leave the code already there as is, and new code using MACRO define for IO? This sounds reasonable, I can agree on this. I send this patch because I see there is a patch from Andy using MACRO for many IOs, but not complete enough and my patch suppose to make all Rockchip IO has update. Thanks, - Kever > > In any case though, this needs to be split into separate arm32/arm64 > patches. > > > Heiko >