From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932779AbcILPXD (ORCPT ); Mon, 12 Sep 2016 11:23:03 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:25302 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395AbcILPXA (ORCPT ); Mon, 12 Sep 2016 11:23:00 -0400 Subject: Re: [PATCH] BUG: atmel_serial: Interrupts not disabled on close To: Richard Genoud , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" References: <20160912133441.14597-1-richard.genoud@gmail.com> CC: Alexandre Belloni , Cyrille Pitchen , , , From: Nicolas Ferre Organization: atmel Message-ID: Date: Mon, 12 Sep 2016 17:22:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160912133441.14597-1-richard.genoud@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.145.133.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 12/09/2016 à 15:34, Richard Genoud a écrit : > Since commit 18dfef9c7f87 ("serial: atmel: convert to irq handling > provided mctrl-gpio"), interrupts from GPIOs are not disabled any more > when the serial port is closed, leading to an oops when the one of the > input pin is toggled (CTS/DSR/DCD/RNG). > > This is only the case if those pins are used as GPIOs, i.e. declared > like that: > usart1: serial@f8020000 { > /* CTS and DTS will be handled by GPIO */ > status = "okay"; > rts-gpios = <&pioB 17 GPIO_ACTIVE_LOW>; > cts-gpios = <&pioB 16 GPIO_ACTIVE_LOW>; > dtr-gpios = <&pioB 14 GPIO_ACTIVE_LOW>; > dsr-gpios = <&pioC 31 GPIO_ACTIVE_LOW>; > rng-gpios = <&pioB 12 GPIO_ACTIVE_LOW>; > dcd-gpios = <&pioB 15 GPIO_ACTIVE_LOW>; > }; > > That's because modem interrupts used to be freed in atmel_shutdown(). > After commit 18dfef9c7f87 ("serial: atmel: convert to irq handling > provided mctrl-gpio"), this code was just removed. > Calling atmel_disable_ms() disables the interrupts and everything works > fine again. > > Tested on at91sam9g35-cm > > (This patch doesn't apply on -stable kernels, fixes for 4.4 and 4.7 will > be sent after this one is applied.) > > Signed-off-by: Richard Genoud > Fixes: 18dfef9c7f87 ("serial: atmel: convert to irq handling provided mctrl-gpio") I thinks it's a bit late for "4.8-fixes". Greg, tell me if you want that I add the Cc: stable tag to this patch (as advised by Uwe) and re-send? Acked-by: Nicolas Ferre Thanks Richard! Best regards, > --- > drivers/tty/serial/atmel_serial.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c > index 2eaa18ddef61..8bbde52db376 100644 > --- a/drivers/tty/serial/atmel_serial.c > +++ b/drivers/tty/serial/atmel_serial.c > @@ -1929,6 +1929,9 @@ static void atmel_shutdown(struct uart_port *port) > { > struct atmel_uart_port *atmel_port = to_atmel_uart_port(port); > > + /* Disable modem control lines interrupts */ > + atmel_disable_ms(port); > + > /* Disable interrupts at device level */ > atmel_uart_writel(port, ATMEL_US_IDR, -1); > > @@ -1979,8 +1982,6 @@ static void atmel_shutdown(struct uart_port *port) > */ > free_irq(port->irq, port); > > - atmel_port->ms_irq_enabled = false; > - > atmel_flush_buffer(port); > } > > -- Nicolas Ferre