From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752026AbeEPEmg (ORCPT ); Wed, 16 May 2018 00:42:36 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:56638 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbeEPEmf (ORCPT ); Wed, 16 May 2018 00:42:35 -0400 To: moderated for non-subscribers From: Randy Dunlap Subject: [PATCH] ASoC: codecs: fix pcm1789.c build errors Cc: =?UTF-8?Q?Myl=c3=a8ne_Josserand?= , LKML , Liam Girdwood , Mark Brown , Andrew Morton , kbuild test robot Message-ID: Date: Tue, 15 May 2018 21:42:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix build errors in pcm1789.c. The source file needs to #include since it uses interfaces and macros that are provided by it. However, it does not need to #include , so drop it. Fixes these build errors: ../sound/soc/codecs/pcm1789.c: In function 'pcm1789_common_init': ../sound/soc/codecs/pcm1789.c:247:2: error: implicit declaration of function 'devm_gpiod_get_optional' [-Werror=implicit-function-declaration] pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); ../sound/soc/codecs/pcm1789.c:247:57: error: 'GPIOD_OUT_HIGH' undeclared (first use in this function) pcm1789->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); ../sound/soc/codecs/pcm1789.c:251:2: error: implicit declaration of function 'gpiod_set_value_cansleep' [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(pcm1789->reset, 0); Fixes: 4ae340d1be36 ("ASoC: codecs: Add support for PCM1789") Reported-by: kbuild test robot Signed-off-by: Randy Dunlap Cc: Mylène Josserand Cc: Liam Girdwood Cc: Mark Brown Cc: alsa-devel@alsa-project.org --- sound/soc/codecs/pcm1789.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) BTW, MODULE_AUTHOR() still uses @free-electrons.com. --- lnx-417-rc4.orig/sound/soc/codecs/pcm1789.c +++ lnx-417-rc4/sound/soc/codecs/pcm1789.c @@ -3,7 +3,7 @@ // Copyright (C) 2018 Bootlin // Mylène Josserand -#include +#include #include #include