From: Joe Perches <joe@perches.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jiri Kosina <trivial@kernel.org>
Subject: Re: git grep/sed to standardize "/* SPDX-License-Identifier: <license>"
Date: Sun, 11 Oct 2020 11:47:34 -0700 [thread overview]
Message-ID: <c99fef41f3cd28784c79dc8cee11e5e8409e7b40.camel@perches.com> (raw)
In-Reply-To: <CAHk-=wiKT9j821qfbb7cs10RPcoaWTtHCjuQzgmaMLk+zZeOOA@mail.gmail.com>
On Sun, 2020-10-11 at 11:42 -0700, Linus Torvalds wrote:
> On Tue, Oct 6, 2020 at 4:13 PM Joe Perches <joe@perches.com> wrote:
> > Almost all source files in the kernel use a standardized SPDX header
> > at line 1 with a comment /* initiator and terminator */:
> >
> > /* SPDX-License-Identifier: <license> */
> >
> > $ git grep -PHn '^/\* SPDX-License-Identifier:.*\*/\s*$' | \
> > wc -l
> > 17847
>
> That grep pattern makes zero sense.
>
> Why would */ be special at all? It isn't.
>
> $ git grep SPDX-License-Identifier: | wc -l
> 52418
>
> and a *LOT* of those are shell scripts and use "#", or are C sources
> and use "//" etc.
>
> So your "standardization" is completely pointless. Anybody who expects
> that pattern just doing something fundamentally wrong, because the
> pattern you want to standardize around is simply not valid.
It's just a trivial grep pattern to determine if the c90 style
SPDX-License-Identifier is in an individual single line comment.
Almost all are.
next prev parent reply other threads:[~2020-10-11 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 23:13 Joe Perches
2020-10-11 18:42 ` Linus Torvalds
2020-10-11 18:47 ` Joe Perches [this message]
2020-10-11 20:29 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c99fef41f3cd28784c79dc8cee11e5e8409e7b40.camel@perches.com \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®