From: Hannes Reinecke <hare@suse.de>
To: Willem Riede <osst@riede.org>
Cc: "Christoph Hellwig" <hch@lst.de>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"Lee Duncan" <lduncan@suse.com>,
"Chris Leech" <cleech@redhat.com>,
"Doug Gilbert" <dgilbert@interlog.com>,
"Jens Axboe" <axboe@kernel.dk>,
"Kai Mäkisara" <Kai.Makisara@kolumbus.fi>,
linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
osst-users@lists.sourceforge.net, linux-kernel@vger.kernel.org,
"Chriosstoph Hellwig" <hch@losst.de>
Subject: Re: [PATCH 24/24] osst: add a SPDX tag to osst.c
Date: Fri, 3 May 2019 10:05:03 +0200 [thread overview]
Message-ID: <c9a58611-13e2-8e13-b573-b504032c017c@suse.de> (raw)
In-Reply-To: <CAKnBiiaSyW27tCqU4i6zStF3AoLPcndSL2gjz1b17LdoFddiiw@mail.gmail.com>
On 5/2/19 9:55 PM, Willem Riede wrote:
> On Thu, May 2, 2019 at 7:19 AM Hannes Reinecke <hare@suse.de
> <mailto:hare@suse.de>> wrote:
>
> On 5/2/19 2:53 PM, Christoph Hellwig wrote:
> > On Thu, May 02, 2019 at 08:06:38AM +0200, Hannes Reinecke wrote:
> >> On 5/1/19 6:14 PM, Christoph Hellwig wrote:
> >>> osst.c is the only osst file missing licensing information. Add a
> >>> GPLv2 tag for the default kernel license.
> >>>
> >>> Signed-off-by: Chriosstoph Hellwig <hch@losst.de
> <mailto:hch@losst.de>>
> >
> > FYI, my s/st/osst/ on the commit message message up my signoff, this
> > should be:
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de <mailto:hch@lst.de>>
> >
> Maybe it's time to kill osst.c for good ...
>
>
> Yes. I've been thinking about doing just that. The devices it supports
> are now thoroughly obsolete. The manufacturer has gone out of business.
> All my test drives have broken down over time, so I can't even test any
> changes any more.
>
Just when I thought to reach out to you :-)
Thing is, we've done numerous changes to the 'st' driver in the course
of the years, most of which seem to have avoided osst :-(
So what's your suggestion here?
Just drop it completely?
Or can we somehow fold the OnStream-specific things back into st.c?
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2019-05-03 8:05 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 16:13 switch core SCSI code to SPDX tags Christoph Hellwig
2019-05-01 16:13 ` [PATCH 01/24] scsi: add SPDX tags to scsi midlayer files missing licensing information Christoph Hellwig
2019-05-02 5:58 ` Hannes Reinecke
2019-05-01 16:13 ` [PATCH 02/24] scsi: switch the remaining scsi midlayer files to use SPDX tags Christoph Hellwig
2019-05-02 5:59 ` Hannes Reinecke
2019-05-01 16:13 ` [PATCH 03/24] scsi_netlink: remove duplicate GPL boilerplate text Christoph Hellwig
2019-05-02 5:59 ` Hannes Reinecke
2019-05-01 16:13 ` [PATCH 04/24] scsi_transport.h: switch to SPDX tags Christoph Hellwig
2019-05-02 5:59 ` Hannes Reinecke
2019-05-01 16:13 ` [PATCH 05/24] scsi_transport_fc: remove duplicate GPL boilerplate text Christoph Hellwig
2019-05-02 6:00 ` Hannes Reinecke
2019-05-01 16:13 ` [PATCH 06/24] scsi_transport_fc: switch to SPDX tags Christoph Hellwig
2019-05-02 6:00 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 07/24] scsi_transport_iscsi: " Christoph Hellwig
2019-05-02 6:01 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 08/24] scsi_transport_sas: " Christoph Hellwig
2019-05-02 6:01 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 09/24] scsi_transport_spi: " Christoph Hellwig
2019-05-02 6:01 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 10/24] scsi_transport_srp: " Christoph Hellwig
2019-05-02 6:02 ` Hannes Reinecke
2019-05-02 15:02 ` Bart Van Assche
2019-05-01 16:14 ` [PATCH 11/24] libfc: remove duplicate GPL boilerplate text Christoph Hellwig
2019-05-02 6:02 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 12/24] libfc: switch to SPDX tags Christoph Hellwig
2019-05-02 6:03 ` Hannes Reinecke
2019-05-14 1:15 ` Martin K. Petersen
2019-05-01 16:14 ` [PATCH 13/24] libfcoe: " Christoph Hellwig
2019-05-02 6:03 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 14/24] libiscsi: " Christoph Hellwig
2019-05-02 6:03 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 15/24] libsas: add a SPDX tag to sas_task.c Christoph Hellwig
2019-05-02 6:04 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 16/24] libsas: switch sas_ata.[ch] to SPDX tags Christoph Hellwig
2019-05-02 6:04 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 17/24] libsas: switch remaining files " Christoph Hellwig
2019-05-02 6:04 ` Hannes Reinecke
2019-05-05 21:20 ` John Garry
2019-05-01 16:14 ` [PATCH 18/24] sd: add a SPDX tag to sd.c Christoph Hellwig
2019-05-02 6:05 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 19/24] sd: switch remaining files to SPDX tags Christoph Hellwig
2019-05-02 6:05 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 20/24] ses: switch " Christoph Hellwig
2019-05-02 6:05 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 21/24] sg: " Christoph Hellwig
2019-05-02 6:05 ` Hannes Reinecke
2019-05-02 15:28 ` Douglas Gilbert
2019-05-05 20:04 ` Douglas Gilbert
2019-05-01 16:14 ` [PATCH 22/24] sr: add a SPDX tag to sr.c Christoph Hellwig
2019-05-02 6:06 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 23/24] st: add a SPDX tag to st.c Christoph Hellwig
2019-05-02 6:06 ` Hannes Reinecke
2019-05-01 16:14 ` [PATCH 24/24] osst: add a SPDX tag to osst.c Christoph Hellwig
2019-05-02 6:06 ` Hannes Reinecke
2019-05-02 12:53 ` Christoph Hellwig
2019-05-02 14:19 ` Hannes Reinecke
[not found] ` <CAKnBiiaSyW27tCqU4i6zStF3AoLPcndSL2gjz1b17LdoFddiiw@mail.gmail.com>
2019-05-03 8:05 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9a58611-13e2-8e13-b573-b504032c017c@suse.de \
--to=hare@suse.de \
--cc=Kai.Makisara@kolumbus.fi \
--cc=axboe@kernel.dk \
--cc=cleech@redhat.com \
--cc=dgilbert@interlog.com \
--cc=hch@losst.de \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=open-iscsi@googlegroups.com \
--cc=osst-users@lists.sourceforge.net \
--cc=osst@riede.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®