From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7A92191F77 for ; Thu, 8 May 2025 02:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746670803; cv=none; b=PH00JFwoU3VHW1guaX7hTJYQtPyg8qRM6rMYm0psS/7QIIcLsee3QlakONnhPVBKnv21WelrlszkTHEof1MOsiXt3iiRL07ZKpgCi+mqx3GgxAWW5kng7m/C8PKpSmbyAHso0yj1j1GJnlAb8W/sbZt6nGicWrJG7B+V1X7wA4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746670803; c=relaxed/simple; bh=hvUBXCA/umxDjIK9pHNEIf1Jrg+wptYYmF9fdTlFkc0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=c6YTxV2yaQVaJ7HOpUGjV8+bBM2LIvmWBcBtiHA4AizV4CryhoV4qCUPOaLsT9PoMWTG++bVgsRGXx0K3ZM67gtjS9YUm00grBvxbkd3LUe2z1ZUsw8TWggsVxR8PTR2dzz6vGNa8j4YDT7Mf3W+ykufQJXO/kFm6xmFAa+Tpwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=qXsnIefA; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="qXsnIefA" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-85b3f92c866so9557939f.3 for ; Wed, 07 May 2025 19:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1746670799; x=1747275599; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BLdPkGjCt3zHlhnTHlv9FcwC/B6Ceh0B+t68w+L9rVI=; b=qXsnIefAw698clpqYte6Cr73FxafEWf97eckVRyOEVGB+ln2H5w4ZU5GNi0ZZVIE+4 GQtd4qa2HOlrLowzJ3dbPaWkyFgtTqCwftQb2SnbfHQkJK9p2sNtrgswtVH4JBQ3l5cv LnFcCv0IT9P6ssDrSPkNGwaeWkj1jtC7PZuPdr5bBPXKXJbYW9FQWd6kld08oRvXzGO6 uaCMRRUrK5EgKD2ZQeNgjosYbLuAyL0SnNOZrpUWda732iClotW/mNfoFTuSUBtmF/bj arTugCX0An5+/ENnLNrpdBQGWHjlS4jQcG29xciuCkr+6kXW83AbGFYQE9zVbpxHVJ2c ScMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746670799; x=1747275599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BLdPkGjCt3zHlhnTHlv9FcwC/B6Ceh0B+t68w+L9rVI=; b=eIVeiNA6tvThTNdTSROPqJcuDZH7ZAn5aXbjq2LBcXOprGGdWMGqnnwFRgF3z7/kHE EEBbA2pitb9CfmAQxohHFMPJ70pkLROkOBF+O3rRpCKHFML6KBJ7PrxgaM4O3ucCMg7h F0ryzPxVsYOoJ1oz1aB7ab3ZDMYAtO9WwgqS+7YLwViqh0IG2xyxL/Ngc+hdbFrmTj0f DKnhK8gAjZjJkGMplfi79CVswL6BXW/ozwElAzKIrpSP7eWh2HKG9GcNx4+xQ9jrKRFm OL04T9DNjOz4YWlwjAbfCEK3AXxCDaO1UUvDHEYf+NwbfnCxFVIGWr7Ph1UWjiJfoVj3 Q9tQ== X-Forwarded-Encrypted: i=1; AJvYcCV0ZJQ8sP+AQVanLiekjEXGIEo28gy8Z1iWCWXM4PC1K/jRu5M2JbkUI0vBTqeFOWGtuTkUX3bdnwsNBgI=@vger.kernel.org X-Gm-Message-State: AOJu0YyElwoHuYPZvP9tZ9YsNzZdAcqQ4wA4MXzVbvc0M5fos/viGtSs gdB7NZaSRYYIA7Lpmv2S41/Il2rixCYSg18np2AQX9LPRsTTMHr8HCK8+rn5e/A= X-Gm-Gg: ASbGncvAJF4r3dEjPV4bUlhK7TCKM+fmv+N9bYp5BEAMbnkVVwGVG9d/+yZ1/45oLE7 t7gYEkffuVeNzX9PufF7BHgxi4a5WXMaxbwQ0nJdCYHxxQwnQnmXE65NtAzUOOt9K1FtJDRTaTO OYFYBMsHU3ojtyDUcf7mcVaaBUynsnP8BdPq9KvrvpdyPj0g8OpkTl9Hg7Q3LXBPG5Frxm1qVYJ XvUrz4b9v521CnYDFZDrVpiryW33BUHA6YzHodJHXvtPcg+S8gpMFkk1fjEZOdm3Ek3liZ3WldD WDu9Qblp/w41M+ZBbD4NWvJAbEw7fvoj0Dc5VGY9WBAI8jfT+se7PQiR+p0eO6LQq4z84IpFmB6 1ChV0 X-Google-Smtp-Source: AGHT+IHghU5JB92rQb5/laIi7WxHhA2dq9+e76tP2eBE8wVgOV2VIOrFMw9IYclbvj3Kg1D1ug4KfA== X-Received: by 2002:a05:6602:1589:b0:867:40d9:bf7e with SMTP id ca18e2360f4ac-867473b3bf4mr660105739f.9.1746670796681; Wed, 07 May 2025 19:19:56 -0700 (PDT) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4f88a8d0071sm2975776173.1.2025.05.07.19.19.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 May 2025 19:19:56 -0700 (PDT) Message-ID: Date: Wed, 7 May 2025 21:19:54 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets To: Yixun Lan Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, heylenay@4d2.org, inochiama@outlook.com, guodong@riscstar.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20250506210638.2800228-1-elder@riscstar.com> <20250506210638.2800228-2-elder@riscstar.com> <20250507223554-GYA505240@gentoo> Content-Language: en-US From: Alex Elder In-Reply-To: <20250507223554-GYA505240@gentoo> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/25 5:35 PM, Yixun Lan wrote: > hi Alex, > > On 16:06 Tue 06 May , Alex Elder wrote: >> There are additional SpacemiT syscon CCUs whose registers control both >> clocks and resets: RCPU, RCPU2, and APBC2. Unlike those defined >> previously, these will (initially) support only resets. They do not >> incorporate power domain functionality. >> >> Previously the clock properties were required for all compatible nodes. >> Make that requirement only apply to the three existing CCUs (APBC, APMU, >> and MPMU), so that the new reset-only CCUs can go without specifying them. >> >> Define the index values for resets associated with all SpacemiT K1 >> syscon nodes, including those with clocks already defined, as well as >> the new ones (without clocks). >> >> Signed-off-by: Alex Elder >> Reviewed-by: Krzysztof Kozlowski >> --- >> .../soc/spacemit/spacemit,k1-syscon.yaml | 29 +++- >> .../dt-bindings/clock/spacemit,k1-syscon.h | 128 ++++++++++++++++++ >> 2 files changed, 150 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml >> index 30aaf49da03d3..133a391ee68cd 100644 >> --- a/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml >> +++ b/Documentation/devicetree/bindings/soc/spacemit/spacemit,k1-syscon.yaml >> @@ -19,6 +19,9 @@ properties: >> - spacemit,k1-syscon-apbc >> - spacemit,k1-syscon-apmu >> - spacemit,k1-syscon-mpmu >> + - spacemit,k1-syscon-rcpu >> + - spacemit,k1-syscon-rcpu2 >> + - spacemit,k1-syscon-apbc2 >> >> reg: >> maxItems: 1 >> @@ -47,9 +50,6 @@ properties: >> required: >> - compatible >> - reg >> - - clocks >> - - clock-names >> - - "#clock-cells" >> - "#reset-cells" >> >> allOf: >> @@ -57,13 +57,28 @@ allOf: >> properties: >> compatible: >> contains: >> - const: spacemit,k1-syscon-apbc >> + enum: >> + - spacemit,k1-syscon-apmu >> + - spacemit,k1-syscon-mpmu >> then: >> - properties: >> - "#power-domain-cells": false >> - else: >> required: >> - "#power-domain-cells" >> + else: >> + properties: >> + "#power-domain-cells": false >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - spacemit,k1-syscon-apbc >> + - spacemit,k1-syscon-apmu >> + - spacemit,k1-syscon-mpmu >> + then: >> + required: >> + - clocks >> + - clock-names >> + - "#clock-cells" >> >> additionalProperties: false >> >> diff --git a/include/dt-bindings/clock/spacemit,k1-syscon.h b/include/dt-bindings/clock/spacemit,k1-syscon.h >> index 35968ae982466..f5965dda3b905 100644 >> --- a/include/dt-bindings/clock/spacemit,k1-syscon.h >> +++ b/include/dt-bindings/clock/spacemit,k1-syscon.h > would it be better to move all reset definition to its dedicated dir? > which like: include/dt-bindings/reset/spacemit,k1-syscon.h? That's fine with me. I should have thought of that. Krzysztof, I'll drop your Reviewed-by if I make that change, but if you say I can before I post v7 I will keep it. I'll wait a bit more before I update so others can comment (on this or anything else). Thanks. -Alex > >> @@ -78,6 +78,9 @@ >> #define CLK_APB 31 >> #define CLK_WDT_BUS 32 >> >> +/* MPMU resets */ >> +#define RESET_WDT 0 >> + >> /* APBC clocks */ >> #define CLK_UART0 0 >> #define CLK_UART2 1 >> @@ -180,6 +183,59 @@ >> #define CLK_TSEN_BUS 98 >> #define CLK_IPC_AP2AUD_BUS 99 >> >> +/* APBC resets */ >> +#define RESET_UART0 0 >> +#define RESET_UART2 1 >> +#define RESET_UART3 2 >> +#define RESET_UART4 3 >> +#define RESET_UART5 4 >> +#define RESET_UART6 5 >> +#define RESET_UART7 6 >> +#define RESET_UART8 7 >> +#define RESET_UART9 8 >> +#define RESET_GPIO 9 >> +#define RESET_PWM0 10 >> +#define RESET_PWM1 11 >> +#define RESET_PWM2 12 >> +#define RESET_PWM3 13 >> +#define RESET_PWM4 14 >> +#define RESET_PWM5 15 >> +#define RESET_PWM6 16 >> +#define RESET_PWM7 17 >> +#define RESET_PWM8 18 >> +#define RESET_PWM9 19 >> +#define RESET_PWM10 20 >> +#define RESET_PWM11 21 >> +#define RESET_PWM12 22 >> +#define RESET_PWM13 23 >> +#define RESET_PWM14 24 >> +#define RESET_PWM15 25 >> +#define RESET_PWM16 26 >> +#define RESET_PWM17 27 >> +#define RESET_PWM18 28 >> +#define RESET_PWM19 29 >> +#define RESET_SSP3 30 >> +#define RESET_RTC 31 >> +#define RESET_TWSI0 32 >> +#define RESET_TWSI1 33 >> +#define RESET_TWSI2 34 >> +#define RESET_TWSI4 35 >> +#define RESET_TWSI5 36 >> +#define RESET_TWSI6 37 >> +#define RESET_TWSI7 38 >> +#define RESET_TWSI8 39 >> +#define RESET_TIMERS1 40 >> +#define RESET_TIMERS2 41 >> +#define RESET_AIB 42 >> +#define RESET_ONEWIRE 43 >> +#define RESET_SSPA0 44 >> +#define RESET_SSPA1 45 >> +#define RESET_DRO 46 >> +#define RESET_IR 47 >> +#define RESET_TSEN 48 >> +#define RESET_IPC_AP2AUD 49 >> +#define RESET_CAN0 50 >> + >> /* APMU clocks */ >> #define CLK_CCI550 0 >> #define CLK_CPU_C0_HI 1 >> @@ -244,4 +300,76 @@ >> #define CLK_V2D 60 >> #define CLK_EMMC_BUS 61 >> >> +/* APMU resets */ >> +#define RESET_CCIC_4X 0 >> +#define RESET_CCIC1_PHY 1 >> +#define RESET_SDH_AXI 2 >> +#define RESET_SDH0 3 >> +#define RESET_SDH1 4 >> +#define RESET_SDH2 5 >> +#define RESET_USBP1_AXI 6 >> +#define RESET_USB_AXI 7 >> +#define RESET_USB3_0 8 >> +#define RESET_QSPI 9 >> +#define RESET_QSPI_BUS 10 >> +#define RESET_DMA 11 >> +#define RESET_AES 12 >> +#define RESET_VPU 13 >> +#define RESET_GPU 14 >> +#define RESET_EMMC 15 >> +#define RESET_EMMC_X 16 >> +#define RESET_AUDIO 17 >> +#define RESET_HDMI 18 >> +#define RESET_PCIE0 19 >> +#define RESET_PCIE1 20 >> +#define RESET_PCIE2 21 >> +#define RESET_EMAC0 22 >> +#define RESET_EMAC1 23 >> +#define RESET_JPG 24 >> +#define RESET_CCIC2PHY 25 >> +#define RESET_CCIC3PHY 26 >> +#define RESET_CSI 27 >> +#define RESET_ISP_CPP 28 >> +#define RESET_ISP_BUS 29 >> +#define RESET_ISP 30 >> +#define RESET_ISP_CI 31 >> +#define RESET_DPU_MCLK 32 >> +#define RESET_DPU_ESC 33 >> +#define RESET_DPU_HCLK 34 >> +#define RESET_DPU_SPIBUS 35 >> +#define RESET_DPU_SPI_HBUS 36 >> +#define RESET_V2D 37 >> +#define RESET_MIPI 38 >> +#define RESET_MC 39 >> + >> +/* RCPU resets */ >> +#define RESET_RCPU_SSP0 0 >> +#define RESET_RCPU_I2C0 1 >> +#define RESET_RCPU_UART1 2 >> +#define RESET_RCPU_IR 3 >> +#define RESET_RCPU_CAN 4 >> +#define RESET_RCPU_UART0 5 >> +#define RESET_RCPU_HDMI_AUDIO 6 >> + >> +/* RCPU2 resets */ >> +#define RESET_RCPU2_PWM0 0 >> +#define RESET_RCPU2_PWM1 1 >> +#define RESET_RCPU2_PWM2 2 >> +#define RESET_RCPU2_PWM3 3 >> +#define RESET_RCPU2_PWM4 4 >> +#define RESET_RCPU2_PWM5 5 >> +#define RESET_RCPU2_PWM6 6 >> +#define RESET_RCPU2_PWM7 7 >> +#define RESET_RCPU2_PWM8 8 >> +#define RESET_RCPU2_PWM9 9 >> + >> +/* APBC2 resets */ >> +#define RESET_APBC2_UART1 0 >> +#define RESET_APBC2_SSP2 1 >> +#define RESET_APBC2_TWSI3 2 >> +#define RESET_APBC2_RTC 3 >> +#define RESET_APBC2_TIMERS0 4 >> +#define RESET_APBC2_KPC 5 >> +#define RESET_APBC2_GPIO 6 >> + >> #endif /* _DT_BINDINGS_SPACEMIT_CCU_H_ */ >> -- >> 2.45.2 >> >