From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AC5929B22F for ; Fri, 6 Mar 2026 10:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794736; cv=none; b=YROCRzNAVBT/qkUb5RsZnJl7+AOSWmKO7m3ZMUmg1bMwXQ8L1RH5cO76X/c4uGOXgLNuAnCkzgVoEPC3IFASh0gASM0GDUpCxWl+YretGapGZLEbIqhEGYk9aJQyQXQ3X0wj9m/N/ttFvJMxdXfYU3tdf6B8DtCsvmgcQrbFaNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772794736; c=relaxed/simple; bh=Y4wrLPuVX7srnbblTwI31RPCAFoDu+8T1SGaO81gAkQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IkebLwjbXincDGu2yUDhYoKzBR8yqinL6569t17OHKxQ6IMpmiemrcd9ZLcd+zBaXjnV1Y/GRx9roG1upvl1lB2F9AgYy6H03CtxomzvW6tKMAdlwKtzHSaKFuCz+33a4JKE0KqOIqO2cIC7UjQxX067YC+09iLFPbXvpiEvAoQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mpyre+aY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JF43qghh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mpyre+aY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JF43qghh" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626AUJKx3296744 for ; Fri, 6 Mar 2026 10:58:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ENeJQR/osskk9CeVIGiXkuHc7GD0Wvkcf5KpQhI7KjA=; b=mpyre+aYbwpIG+PA NWRzHnk1RkoJz/c0e0su7nxe2kOBF0i07dNfpSzPHDcdpVKJFGwA863S1ORebO2m +bmWRNUnMidZln4vF0O+OasxBhLSPMx5OSdL8cKIDyNszcLhq3HnmYv9cntPjhZd XJh+vRs72wOW7kVK4zQPoYddK6mV/FUEAAAWaqh5C8T/qjd4qBmUk3NNwuivcqNO OcL/wPyKM2IWGi3q+Zbtb0WiLQrJa6qP/URU/POwLQcWcqSaQEgtgJCctnAonuRQ rIB5+peKfBHJrPukN6YM5yoMpmlUZKtMcDMUkyqQ7259Y4V12KBF9aMcODBvPq1l p+SgCQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqpxdsfsv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 10:58:54 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c7387c70046so1230501a12.0 for ; Fri, 06 Mar 2026 02:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772794733; x=1773399533; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ENeJQR/osskk9CeVIGiXkuHc7GD0Wvkcf5KpQhI7KjA=; b=JF43qghhmJfjuyhHQcDTuuNgmyWsEs88Sxh2PoqbZkeRRPkHvbVJDk8vykhIUVYbQc JJFjZI9JyUnmpL+Jd86NGNOjEvYIULNluF3Om5xy0Q/Z1YERZjZgcZN1PvnxAL8e+PIY IFBL1rrVJK5L/1852vsNC8NbeYG+R0kKQ7V/i11W5KPkbK5Ra0sJ4BnhUVPTDu8hAG4z CWDr9BjJarNKhJ6+i1r2tK59sOP3hDMSlc+ah3gb+x6guJb/gbCP6YvtW1a+SDRgbTuO 9opjIbumtYaevARLhG3wZoBOQSONbp7M3+lw/PbtGpHYR+TujTfUKZ2t9MpP3+sSE9Mh PLcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772794733; x=1773399533; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ENeJQR/osskk9CeVIGiXkuHc7GD0Wvkcf5KpQhI7KjA=; b=W65V93atVg29muHggEYkirOCtjVqAlAgyEiExODHdpjwM1S0AAUEUqT8Pw/jw7g0kb ooPoQJSjmlLqvnEcSxyApnneLUHHudvvIWc5dv1zHpB1wZSnVakwa/zDH/dP3BWkepDD ogazwoStlC2/205ZXQD/vqQ7twPLDByQqRuw2g3uYHuXnhGlY2Nlaiu59939oz7r+6i0 0du+Z/JfdIsZKgQnJvdCtzYcVNr10x3vFD+WcyucUK5+VmQKBbBwhNCSmwCBzh2ZbO/b 7BHElwC10oK6/dVr62eIRaE1mGe8EgTFxekxYNwoXXv3G3kKVMc3Ij1ylXdhBp9pw74z drUg== X-Forwarded-Encrypted: i=1; AJvYcCVBiGiJv1LIkSypso52dZ1Xze0qpQJ9XXxssVXet0G/wfWqD2aUlNMR6Q+80PZcHHLhpWT/Cf6IQFVwkOU=@vger.kernel.org X-Gm-Message-State: AOJu0YwOUY2WdRD/wB040A4YRQby4L6r/tQvwDmnYE6k5W9NcVywbeVB it3N7ggHNbwW9NyhnFySf9CMtadBIYG861z3BKoZfDT5bvwIAi3jBZle+qQIcYAWs5N7QVB5hUI csHrB8K824favLiqH1SPzYogryLFgJLaLUdwQRE045PaxSVDLDmUOSqK/z6Lk0JIWfyc= X-Gm-Gg: ATEYQzzb78JIpR9hvTlBF6JrclTQzi/F9qOWCBckRezTB7n93wxpX+oLJLgog8LLTr1 wwXllpKdbj+zgpiUnT3B6bHYM9oGC9FChLHPXdbYi09BO1Tb1rUYd6BmTbU46VPbIcFF3Xvg8AP KC14BASAmDSLbivhLJKqQCA/4Di1iT1li0D2/dMKW6jwbDKmfJ6UGdx8xzzJ3dJ0Z+5jdp1sDA6 WlNMhMWf7lYJ/620OlZV0RZAqkcSd5I+yAGMwREuzgNm5xGBV8hbNNhMcmVqe8GOc15g0zGjxIj ncoBsaQdWcqLK8S4ZejZ+FrxVLzvu0dUvtdPSBDvZgU4/UJlWsQOUoowYWOBaQ0zgEeVl+t8V3c KvVghBFBgzMGWZt/svJ9ULYmmp8KnX1cNCemBC7EEbFrrrhKwTZIMzg== X-Received: by 2002:a05:6a20:734b:b0:38e:9c27:72e2 with SMTP id adf61e73a8af0-39858fe2873mr1933256637.28.1772794733437; Fri, 06 Mar 2026 02:58:53 -0800 (PST) X-Received: by 2002:a05:6a20:734b:b0:38e:9c27:72e2 with SMTP id adf61e73a8af0-39858fe2873mr1933235637.28.1772794732914; Fri, 06 Mar 2026 02:58:52 -0800 (PST) Received: from [10.0.0.3] ([106.222.231.181]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c739e195c40sm1307204a12.31.2026.03.06.02.58.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 02:58:52 -0800 (PST) Message-ID: Date: Fri, 6 Mar 2026 16:28:48 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 10/11] media: qcom: iris: split firmware_data from raw platform data Content-Language: en-US To: Dmitry Baryshkov , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-iris-platform-data-v2-0-acf036a3c84c@oss.qualcomm.com> <20260228-iris-platform-data-v2-10-acf036a3c84c@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260228-iris-platform-data-v2-10-acf036a3c84c@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: JyydgbsS3qPOqvUENNSRz_321xARwX-Q X-Authority-Analysis: v=2.4 cv=E83AZKdl c=1 sm=1 tr=0 ts=69aab36e cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=IrIcjQS8YOhLhDNCWt0oYA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=deA5lg_RuNhAItBNuyoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDEwNCBTYWx0ZWRfX+4xpj1YqUMyM FqsKbL5DlGRTHfRfhKmKGHwik/dW2aYYw+QzH+0lTFOni4w2+BI9VftPQKHSS2TsvKa8fS0gFVP VA6v1Pp58lLsmG3mQfC2B5CoQY7rCJ9QOELYcXpTRb3wvtu6gxaSr5U10I12AKhtgs1QKbTwVNg vfqE/ZprkqMcOT2/BluE1z7YjLir6Gw08Op/U9s4nqYqw89RHdHJwfdcImKxqJzOErk8W+uUQlc yQE4fXwvFF1Gq61W7na2sPFqNcd0GLkYfO3je83VKn0uV5TqsQtvJnaRdav7J7BhmMhy6pwNRvp n4aKrjnm/5Dw+s85boB4mYjViNse8TbZlxlb+xxQErpSf2NupT/lUBkGO8UVg5sD7ECTKFKyJh3 4CG1E67JHLPM1rljXwCKFuMwD02mw2J+9pttx4xB74yaZU66UPzz856uax/GSGSKbhzBo7d+tmt RSKotxf3M2HtixRgm8g== X-Proofpoint-GUID: JyydgbsS3qPOqvUENNSRz_321xARwX-Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_03,2026-03-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060104 On 2/28/2026 8:56 PM, Dmitry Baryshkov wrote: > diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h > index a936ab2aedaf..be3449861993 100644 > --- a/drivers/media/platform/qcom/iris/iris_platform_common.h > +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h > @@ -201,9 +201,32 @@ enum platform_pm_domain_type { > IRIS_APV_HW_POWER_DOMAIN, > }; > > -struct iris_platform_data { > +struct iris_firmware_data { > void (*init_hfi_ops)(struct iris_core *core); > + > u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type buffer_type); Makes sense to split firmware-related data out of iris_platform_data into a dedicated iris_firmware_data, one comment though, get_vpu_buffer_size should be in iris_platform_data since it describes the VPU’s buffer requirements independent of whether the SoC runs gen1/gen2 HFI firmware. Thanks, Dikshita > + > + const struct platform_inst_fw_cap *inst_fw_caps_dec; > + u32 inst_fw_caps_dec_size; > + const struct platform_inst_fw_cap *inst_fw_caps_enc; > + u32 inst_fw_caps_enc_size; > + > + const u32 *dec_ip_int_buf_tbl; > + unsigned int dec_ip_int_buf_tbl_size; > + const u32 *dec_op_int_buf_tbl; > + unsigned int dec_op_int_buf_tbl_size; > + const u32 *enc_ip_int_buf_tbl; > + unsigned int enc_ip_int_buf_tbl_size; > + const u32 *enc_op_int_buf_tbl; > + unsigned int enc_op_int_buf_tbl_size; > +}; > + > +struct iris_platform_data { > + /* > + * XXX: remove firmware_data pointer once we have platforms supporting > + * both firmware kinds. > + */ > + const struct iris_firmware_data *firmware_data; > const struct vpu_ops *vpu_ops; > void (*set_preset_registers)(struct iris_core *core); > const struct icc_info *icc_tbl; > @@ -226,10 +249,6 @@ struct iris_platform_data { > struct iris_fmt *inst_iris_fmts; > u32 inst_iris_fmts_size; > struct platform_inst_caps *inst_caps; > - const struct platform_inst_fw_cap *inst_fw_caps_dec; > - u32 inst_fw_caps_dec_size; > - const struct platform_inst_fw_cap *inst_fw_caps_enc; > - u32 inst_fw_caps_enc_size; > const struct tz_cp_config *tz_cp_config_data; > u32 tz_cp_config_data_size; > u32 core_arch; > @@ -241,14 +260,6 @@ struct iris_platform_data { > u32 max_core_mbpf; > /* max number of macroblocks per second supported */ > u32 max_core_mbps; > - const u32 *dec_ip_int_buf_tbl; > - unsigned int dec_ip_int_buf_tbl_size; > - const u32 *dec_op_int_buf_tbl; > - unsigned int dec_op_int_buf_tbl_size; > - const u32 *enc_ip_int_buf_tbl; > - unsigned int enc_ip_int_buf_tbl_size; > - const u32 *enc_op_int_buf_tbl; > - unsigned int enc_op_int_buf_tbl_size; > }; > > #endif