From: Dan Scally <dan.scally@ideasonboard.com>
To: "Jacopo Mondi" <jacopo.mondi@ideasonboard.com>,
"Anthony McGivern" <anthony.mcgivern@arm.com>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Nayden Kanchev" <Nayden.Kanchev@arm.com>,
"Konstantin Babin" <Konstantin.Babin@arm.com>,
"Barnabás Pőcze" <barnabas.pocze@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH 1/6] media: mali-c55: Fix wrong comment of ISP block types
Date: Fri, 13 Mar 2026 11:26:46 +0000 [thread overview]
Message-ID: <c9ab7242-2d40-4eec-a09b-efce4dd222c6@ideasonboard.com> (raw)
In-Reply-To: <20260313-mali-c55-fixes-v7-0-v1-1-21805b2b516b@ideasonboard.com>
Hi Jacopo
On 13/03/2026 10:49, Jacopo Mondi wrote:
> Some bad copy&paste happened in the description of the ISP block types
> and AWB_CONFIG got mixed up with SHADING_CONFIG.
>
> Fix it by assigning to each block the correct type.
>
> As only the comment is changed, there is no uABI breakage or regression.
>
> Cc: stable@vger.kernel.org
> Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver")
> Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> ---
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
> drivers/media/platform/arm/mali-c55/mali-c55-params.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-params.c b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> index be0e909bcf29..c03a6120ddbf 100644
> --- a/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> +++ b/drivers/media/platform/arm/mali-c55/mali-c55-params.c
> @@ -43,9 +43,9 @@
> * @digital_gain: For header->type == MALI_C55_PARAM_BLOCK_DIGITAL_GAIN
> * @awb_gains: For header->type == MALI_C55_PARAM_BLOCK_AWB_GAINS and
> * header->type = MALI_C55_PARAM_BLOCK_AWB_GAINS_AEXP
> - * @awb_config: For header->type == MALI_C55_PARAM_MESH_SHADING_CONFIG
> - * @shading_config: For header->type == MALI_C55_PARAM_MESH_SHADING_SELECTION
> - * @shading_selection: For header->type == MALI_C55_PARAM_BLOCK_SENSOR_OFFS
> + * @awb_config: For header->type == MALI_C55_PARAM_BLOCK_AWB_CONFIG
> + * @shading_config: For header->type == MALI_C55_PARAM_MESH_SHADING_CONFIG
> + * @shading_selection: For header->type == MALI_C55_PARAM_MESH_SHADING_SELECTION
> * @data: Allows easy initialisation of a union variable with a
> * pointer into a __u8 array.
> */
>
next prev parent reply other threads:[~2026-03-13 11:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 10:49 [PATCH 0/6] media: mali-c55: Fix ISP reset and blocks bypass Jacopo Mondi
2026-03-13 10:49 ` [PATCH 1/6] media: mali-c55: Fix wrong comment of ISP block types Jacopo Mondi
2026-03-13 11:26 ` Dan Scally [this message]
2026-03-13 10:49 ` [PATCH 2/6] media: mali-c55: Initialize the ISP in enable_streams() Jacopo Mondi
2026-03-13 10:49 ` [PATCH 3/6] media: mali-c55: Fully reset the ISP configuration Jacopo Mondi
2026-03-13 10:49 ` [PATCH 4/6] media: mali-c55: Fix Iridix bypass macros Jacopo Mondi
2026-03-13 11:15 ` Barnabás Pőcze
2026-03-13 11:37 ` Jacopo Mondi
2026-03-13 10:49 ` [PATCH 5/6] media: mali-c55: Bypass the Iridix Tonemap engine Jacopo Mondi
2026-03-13 10:49 ` [PATCH 6/6] media: mali-c55: Bypass Purple Fringe Correction Jacopo Mondi
2026-03-13 11:15 ` Barnabás Pőcze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9ab7242-2d40-4eec-a09b-efce4dd222c6@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=Konstantin.Babin@arm.com \
--cc=Nayden.Kanchev@arm.com \
--cc=anthony.mcgivern@arm.com \
--cc=barnabas.pocze@ideasonboard.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®