From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f43.google.com (mail-yx1-f43.google.com [74.125.224.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 708402882D7 for ; Mon, 24 Nov 2025 02:34:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763951652; cv=none; b=Hu4bn+dOMbjA84m5x3OZQixidF+l0vI+miOCRrj9Pj7ugVXtgRUKAS+VZBmQAP5EUq+HEduQYgPrKsywDQTUt75lBaRTAGPzqw/WUoMzOgdvIOictLKPM2+fkykBkkfeDzFGxNuanFQGY9Eu9YBuXkwVHeEYWUfllVWF0TceQX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763951652; c=relaxed/simple; bh=u50wiEtGTDGab7ZHLTtEof0ZVgdLfgY/RffYitv2A9Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IPcjZyfEntzPlKh0Kb8y73uS++NCq0R0H6j1c0S6J5D14nWg3bgWudoTtT24Ea2ZH8G9qyA8Vwhj4AAFKw/O19ZXb35Ofd0Tk1Av3am2VPcxXimMkF2u9CjH7rjRzXGr/purSRojTTM1pgLcFbe5BC5BuzpvRn3JOabXSllqRXU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=m8x/Irwa; arc=none smtp.client-ip=74.125.224.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="m8x/Irwa" Received: by mail-yx1-f43.google.com with SMTP id 956f58d0204a3-63f9beb2730so2895661d50.0 for ; Sun, 23 Nov 2025 18:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763951649; x=1764556449; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=kJnKQ9oJ9uOzEtfzk8AKk4PwanNXBUdVi5ibWSqh/IQ=; b=m8x/IrwaiGnCb0YBQz7bEJk0cbf46DK1nrNm2Kwf8vW9VvfhJto4J7VC6xJdKeWM58 GEWqUnq2+rVPoIN+62SlrcgIizlmxlvmG50u0HenUdY3x7ttd2jzBxl7Fo08vaqaJXLU 1lGuLVic55gDwMu+dOLEa9KHlp/YqJCukKMKeiZKRwyyq9WyIypGGv+Kh8wntAI3/Tgs RzDKPQOETilaHBt0vgwifEkDh24ZrSqIkox8G9aqwCOzyXZ+KVBt9nQqpqUahk3jc0yS U/2W2W4UvLW6njF1ue9GuGHZwkt1He9eUc8hRVE0rcX7BMQAttBfHYqs+Iog8XQl53M/ WOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763951649; x=1764556449; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=kJnKQ9oJ9uOzEtfzk8AKk4PwanNXBUdVi5ibWSqh/IQ=; b=f9CquDM2SOoAESgHpEGboRiHw9Gz9EaKj197DTXrj2uzkq+n9mjT112o1kInWkv7tI DwVlLMYQuqlnI10vPiORp6O/Cr8p1dvRnfUXL09ZI+sVSSNwZGp8Brmxh0//ZXf8kUlK w0zeZUOJxy4z/WtYLKm4RRe589ruaKJWWEWww9OWaKjhY5AKrlZf6+NiHhSVg4KR1xCk aznorv4MMDtsC5A8EkIh+z3kQXcja14wsmmMZI9XeN1JJrags4h0YDPx42DU5WJpo/DK hJ2XQGoABw0YYhsaOAxEvP6rVm4LBbEqwZeO6Ezmn/YSDqyqSHdxoVyLXbwBIJBRKQ1U QTDg== X-Gm-Message-State: AOJu0YzmlGIekB+bkYs5L3D5En/8VlYuQKR7Tamgd3T2S8m+3+GZ/JGm YWhPMCe9dg1Xhnl9ITVF2NML9Yjnnrcy5RU7LY/IE9TBBsEX15qLu2IUgydatkwGhg== X-Gm-Gg: ASbGnctKjCqO+085/HFsnvBDwkHyzRVuLOeQ5lhE8/j//S9VDkj5PXiB4myuERocRAX GXacW9q34UVxJnUXrxCPETNx6mRkE+yyROOJ7e8QJFjre19YGaUu2S7cSVpZ12BD+Ow6BzRGQzS WBguXlZ92KOzRJVqSQrbazFpBvr/ElQ33ehsocAG9OX7nuBRKaUx2uhbpEeJgEn2ve7SwBnQPJR +PIzD4zFeGMWL4sZksCjfpeqbV9zmojpcuz7I3X7NxLHPBioabWaeJreJ60Y1/an1qnA/BCMsB4 OwGbguNot/VsCSLcIyrt8aXJeGdtJDm+m3xP4XW4vEe6iaKbWzl89zUoausSco58XGaLB1V9R5v CaYLZlvM4M6lcgdrBKUoBz9ka4hVUdYLHGM3kkbzCjE87h/M9nqf0XEI3MfO04EZ/g4pzfF28cu FTu7QWmkPyWbQ+tU+RCL469UOh6ttm0nJzW/gzCnXJ42TLP11IBljO8Kc42uA= X-Google-Smtp-Source: AGHT+IHxC+BdP7vzl95DrlP/y364+xUvzMJ0RS3cskY282bYh7RWJ066M6U+GDgwPwRF2d9d7KuiRA== X-Received: by 2002:a05:690e:400d:b0:641:f5bc:699a with SMTP id 956f58d0204a3-64302b37d39mr6827251d50.72.1763951649099; Sun, 23 Nov 2025 18:34:09 -0800 (PST) Received: from ?IPV6:2600:1700:4570:89a0:1806:1fd4:facd:d088? ([2600:1700:4570:89a0:1806:1fd4:facd:d088]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78a798a5decsm40005717b3.21.2025.11.23.18.34.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Nov 2025 18:34:08 -0800 (PST) Message-ID: Date: Sun, 23 Nov 2025 18:34:05 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] dt-bindings: power: supply: Add Maxim MAX77759 charger To: Krzysztof Kozlowski , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Lee Jones , Greg Kroah-Hartman , Badhri Jagan Sridharan , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20251123-max77759-charger-v1-0-6b2e4b8f7f54@google.com> <20251123-max77759-charger-v1-1-6b2e4b8f7f54@google.com> From: Amit Sunil Dhamne Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Krzysztof, On 11/23/25 1:28 AM, Krzysztof Kozlowski wrote: > On 23/11/2025 09:35, Amit Sunil Dhamne via B4 Relay wrote: >> From: Amit Sunil Dhamne >> >> Add bindings for Maxim max77759 charger device. >> >> Signed-off-by: Amit Sunil Dhamne >> --- >> .../power/supply/maxim,max77759-charger.yaml | 36 ++++++++++++++++++++++ >> 1 file changed, 36 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max77759-charger.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max77759-charger.yaml >> new file mode 100644 >> index 000000000000..71f866419774 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/supply/maxim,max77759-charger.yaml >> @@ -0,0 +1,36 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/supply/maxim,max77759-charger.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Maxim Integrated MAX77759 Battery charger >> + >> +maintainers: >> + - Amit Sunil Dhamne >> + >> +description: | >> + This module is part of the MAX77759 PMIC. For additional information, see >> + Documentation/devicetree/bindings/mfd/maxim,max77759.yaml. >> + >> + The Maxim MAX77759 is a dual input switch mode battery charger for portable >> + applications. It supports wired and wireless charging and can operate in buck >> + and boost mode. >> + >> +allOf: >> + - $ref: power-supply.yaml# >> + >> +properties: >> + compatible: >> + const: maxim,max77759-charger >> + > This should be just folded into parent node, no need for separate > charger device or is just incomplete. Thanks for the review! You are right, the binding is incomplete. This charger block actually listens on its own I2C address, distinct from the main PMIC. I will update v2 to include the reg property. I will also add the standard properties `constant-charge-current-max-microamp` and `constant-charge-voltage-max-microvolt` to configure the hardware limits, as this charger device does not manage the battery profile directly (that is handled by a separate fuel gauge). Thanks, Amit > >> + usb-otg-vbus-regulator: >> + type: object >> + description: Provides Boost for sourcing VBUS. >> + $ref: /schemas/regulator/regulator.yaml# >> + unevaluatedProperties: false >> + > Best regards, > Krzysztof