mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: ShiHao <i.shihao.999@gmail.com>
Cc: andi.shyti@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	conor+dt@kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: intel,ixp4xx-i2c: Convert to Dt schema
Date: Wed, 25 Mar 2026 16:15:39 +0100	[thread overview]
Message-ID: <c9b68d56-48f1-4ade-8711-fedd8acf0666@kernel.org> (raw)
In-Reply-To: <acP69aM-euL7wl87@fedora>

On 25/03/2026 16:10, ShiHao wrote:
> On Wed, Mar 25, 2026 at 12:16:27PM +0100, Krzysztof Kozlowski wrote:
> 
>> Please run scripts/checkpatch.pl on the patches and fix reported
>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>> patches and (probably) fix more warnings. Some warnings can be ignored,
>> especially from --strict run, but the code here looks like it needs a
>> fix. Feel free to get in touch if the warning is not clear.
>>
> 
> Hello Krzysztof, 
> 
>       Once again thank you for your time. Those warnings are from running
>       checkpatch.pl without the --strict option i myself discovered when you
>       said that because i only use it with --strict option. I thought
>       checkpatch.pl --strict  was more strict then checkpatch.pl but i guess
>       it is not so strict as i thought it was. But apart from this i mean
>       why in the first place there is the --strict option when it is actually
>       not so strict it must have shown all errors, checks and warnings but it
>       does not Anyway i will make sure to run both from now on thanks for pointing
>       it.

I don't understand this at all.

You did not run checkpatch. Neither with --strict nor without --strict.
The --strict does not matter, why are you even mentioning it if you did
not run the checkpatch in the first place?

Best regards,
Krzysztof

  reply	other threads:[~2026-03-25 15:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-24 13:50 Shi Hao
2026-03-25 11:16 ` Krzysztof Kozlowski
2026-03-25 15:10   ` ShiHao
2026-03-25 15:15     ` Krzysztof Kozlowski [this message]
2026-03-25 18:31       ` ShiHao
2026-03-26  7:08         ` Krzysztof Kozlowski
2026-03-28  9:46           ` ShiHao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9b68d56-48f1-4ade-8711-fedd8acf0666@kernel.org \
    --to=krzk@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=i.shihao.999@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®