mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: Jens Axboe <axboe@kernel.dk>,
	Salvatore Bonaccorso <carnil@debian.org>,
	"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>
Cc: Pavel Machek <pavel@denx.de>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-rt-users <linux-rt-users@vger.kernel.org>,
	stable-rt <stable-rt@vger.kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Daniel Wagner <daniel.wagner@suse.com>,
	Tom Zanussi <tom.zanussi@linux.intel.com>,
	Clark Williams <williams@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	Jeff Brady <jeffreyjbrady@gmail.com>
Subject: Re: [ANNOUNCE] 5.10.162-rt78
Date: Fri, 20 Jan 2023 07:01:23 +0100	[thread overview]
Message-ID: <c9b77d7df95c2ae354e655ada0f34ea3c83f0bba.camel@gmx.de> (raw)
In-Reply-To: <a4f62523-b01e-3986-7914-767f999b4153@kernel.dk>

On Thu, 2023-01-19 at 16:09 -0700, Jens Axboe wrote:
>
> I guess we need to twiddle that asm to deal with eg 16 bits, rather than
> attempt to backport any TIF removal patches.

Hm, 'mov' gets past the weird ass rules committee, so seems it should
be trivial for someone who speaks arm.  This built/booted once on rpi4.

diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index d5bc1dbdd2fd..a4931bff8ea9 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -751,7 +760,12 @@ SYM_CODE_START_LOCAL(ret_to_user)
 	bl	trace_hardirqs_off
 #endif
 	ldr	x19, [tsk, #TSK_TI_FLAGS]
+#ifndef CONFIG_PREEMPT_RT
 	and	x2, x19, #_TIF_WORK_MASK
+#else
+	mov	x2, #_TIF_WORK_MASK
+	and	x2, x19, x2
+#endif
 	cbnz	x2, work_pending
 finish_ret_to_user:
 	user_enter_irqoff


      parent reply	other threads:[~2023-01-20  6:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 13:35 Luis Claudio R. Goncalves
2023-01-19  8:32 ` Vignesh Raghavendra
2023-01-19 11:38   ` Pavel Machek
2023-01-19 12:37     ` Pavel Machek
2023-01-19 13:16     ` Luis Claudio R. Goncalves
2023-01-19 21:03       ` Salvatore Bonaccorso
2023-01-19 23:09         ` Jens Axboe
2023-01-20  3:44           ` Luis Claudio R. Goncalves
2023-01-20  3:49             ` Jens Axboe
2023-01-20  5:36               ` Salvatore Bonaccorso
2023-01-20 10:01               ` Daniel Wagner
2023-01-20 14:48                 ` Jens Axboe
2023-01-20 12:51               ` Luis Claudio R. Goncalves
2023-01-20 13:04                 ` Sebastian Andrzej Siewior
2023-01-20 15:37                 ` Mark Rutland
2023-01-20 18:25                   ` Luis Claudio R. Goncalves
2023-01-20 18:38                     ` Salvatore Bonaccorso
2023-01-23 16:32                     ` Mark Rutland
2023-01-28  8:24                       ` Raghavendra, Vignesh
2023-01-20  6:01           ` Mike Galbraith [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9b77d7df95c2ae354e655ada0f34ea3c83f0bba.camel@gmx.de \
    --to=efault@gmx.de \
    --cc=C.Emde@osadl.org \
    --cc=axboe@kernel.dk \
    --cc=bigeasy@linutronix.de \
    --cc=carnil@debian.org \
    --cc=daniel.wagner@suse.com \
    --cc=jeffreyjbrady@gmail.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=pavel@denx.de \
    --cc=rostedt@goodmis.org \
    --cc=stable-rt@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tom.zanussi@linux.intel.com \
    --cc=vigneshr@ti.com \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®