From: Sinan Kaya <okaya@codeaurora.org>
To: linux-pci@vger.kernel.org, timur@codeaurora.org
Cc: mayurkumar.patel@intel.com, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Bjorn Helgaas <bhelgaas@google.com>,
Rajat Jain <rajatja@google.com>,
David Daney <david.daney@cavium.com>,
Yinghai Lu <yinghai@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove
Date: Thu, 30 Mar 2017 09:25:11 -0400 [thread overview]
Message-ID: <c9bbde75-c976-4f7d-8c31-167f6d173994@codeaurora.org> (raw)
In-Reply-To: <1490828667-30973-6-git-send-email-okaya@codeaurora.org>
On 3/29/2017 7:04 PM, Sinan Kaya wrote:
> if (!parent || !parent->link_state)
> return;
>
> + if (pdev->has_secondary_link) {
> + link = pdev->link_state;
I think I accidentally moved the parent check above this code
and broke the case where you can actually remove the root port.
I'll post v7 with reverting this change.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2017-03-30 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1490828667-30973-1-git-send-email-okaya@codeaurora.org>
2017-03-29 23:04 ` [PATCH V6 1/5] PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities() Sinan Kaya
2017-03-29 23:04 ` [PATCH V6 2/5] PCI/ASPM: split pci_aspm_init() into two Sinan Kaya
2017-03-29 23:04 ` [PATCH V6 3/5] PCI/ASPM: add init hook to device_add Sinan Kaya
2017-03-29 23:04 ` [PATCH V6 4/5] PCI/ASPM: save power on values during bridge init Sinan Kaya
2017-03-29 23:04 ` [PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove Sinan Kaya
2017-03-30 13:25 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9bbde75-c976-4f7d-8c31-167f6d173994@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=david.daney@cavium.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mayurkumar.patel@intel.com \
--cc=rajatja@google.com \
--cc=timur@codeaurora.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®