From: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <pure.logic@nexus-software.ie>,
<bjorn.andersson@linaro.org>, <robh@kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_tsoni@quicinc.com>,
<quic_psodagud@quicinc.com>, <quic_satyap@quicinc.com>,
<quic_pheragu@quicinc.com>, <quic_rjendra@quicinc.com>,
<quic_sibis@quicinc.com>, <quic_saipraka@quicinc.com>
Subject: Re: [PATCH V5 3/6] usb: common: eud: Add driver support for Embedded USB Debugger(EUD)
Date: Fri, 4 Feb 2022 12:33:30 +0530 [thread overview]
Message-ID: <c9c1bcb8-74d6-9049-f4ab-e3fdb8a0ae5e@quicinc.com> (raw)
In-Reply-To: <Yfu5Aq7U6ZT1KzcJ@kroah.com>
On 2/3/2022 4:44 PM, Greg KH wrote:
> On Thu, Feb 03, 2022 at 04:04:32PM +0530, Souradeep Chowdhury wrote:
>> Add support for control peripheral of EUD (Embedded USB Debugger) to
>> listen to events such as USB attach/detach, pet EUD to indicate software
>> is functional.Reusing the platform device kobj, sysfs entry 'enable' is
>> created to enable or disable EUD.
>>
>> To enable the eud the following needs to be done
>> echo 1 > /sys/bus/platform/.../enable
>>
>> To disable eud, following is the command
>> echo 0 > /sys/bus/platform/.../enable
>>
>> Signed-off-by: Souradeep Chowdhury <quic_schowdhu@quicinc.com>
>> ---
>> Documentation/ABI/testing/sysfs-driver-eud | 9 ++
>> drivers/usb/common/Kconfig | 10 ++
>> drivers/usb/common/Makefile | 1 +
>> drivers/usb/common/qcom_eud.c | 251 +++++++++++++++++++++++++++++
> This really should be drivers/usb/misc/ right? No other code uses
> anything from this driver which is what "common" is for.
Ack
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2022-02-04 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 10:34 [PATCH V5 0/6] Add Embedded USB Debugger (EUD) driver Souradeep Chowdhury
2022-02-03 10:34 ` [PATCH V5 1/6] dt-bindings: Add the yaml bindings for EUD Souradeep Chowdhury
2022-02-04 22:49 ` Rob Herring
2022-02-03 10:34 ` [PATCH V5 2/6] bindings: usb: dwc3: Update dwc3 properties for EUD connector Souradeep Chowdhury
2022-02-04 22:50 ` Rob Herring
2022-02-03 10:34 ` [PATCH V5 3/6] usb: common: eud: Add driver support for Embedded USB Debugger(EUD) Souradeep Chowdhury
2022-02-03 11:14 ` Greg KH
2022-02-04 7:03 ` Souradeep Chowdhury [this message]
2022-02-03 10:34 ` [PATCH V5 4/6] arm64: dts: qcom: sc7280: Add EUD dt node and dwc3 connector Souradeep Chowdhury
2022-02-03 10:34 ` [PATCH V5 5/6] arm64: dts: qcom: sc7280: Set the default dr_mode for usb2 Souradeep Chowdhury
2022-02-03 10:34 ` [PATCH V5 6/6] MAINTAINERS: Add maintainer entry for EUD Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c1bcb8-74d6-9049-f4ab-e3fdb8a0ae5e@quicinc.com \
--to=quic_schowdhu@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
--cc=quic_pheragu@quicinc.com \
--cc=quic_psodagud@quicinc.com \
--cc=quic_rjendra@quicinc.com \
--cc=quic_saipraka@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®