From: Felix Kuehling <felix.kuehling@amd.com>
To: "Ваторопин Андрей" <a.vatoropin@crpt.ru>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH v3] drm/amdkfd: Change svm_range_get_info return type
Date: Fri, 16 May 2025 13:35:41 -0500 [thread overview]
Message-ID: <c9cabe07-09cc-49a9-8311-6795695c28f6@amd.com> (raw)
In-Reply-To: <20250402141219.372650-1-a.vatoropin@crpt.ru>
On 2025-04-02 10:12, Ваторопин Андрей wrote:
> From: Andrey Vatoropin <a.vatoropin@crpt.ru>
>
> Static analysis shows that pointer "svms" cannot be NULL because it points
> to the object "struct svm_range_list". Remove the extra NULL check. It is
> meaningless and harms the readability of the code.
>
> In the function svm_range_get_info() there is no possibility of failure.
> Therefore, the caller of the function svm_range_get_info() does not need
> a return value. Change the function svm_range_get_info() return type from
> "int" to "void".
>
> Since the function svm_range_get_info() has a return type of "void". The
> caller of the function svm_range_get_info() does not need a return value.
> Delete extra code.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Vatoropin <a.vatoropin@crpt.ru>
Sorry about the long delay. I just applied this patch to amd-staging-drm-next.
Regards,
Felix
> ---
> v1 -> v2: also change return type of svm_range_get_info() per Felix Kuehling suggestion
> v2 -> v3: deleted extra code in the function kfd_criu_checkpoint_svm()
>
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 +---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 9 ++-------
> drivers/gpu/drm/amd/amdkfd/kfd_svm.h | 11 +++++------
> 3 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index 1e9dd00620bf..a2149afa5803 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -2039,9 +2039,7 @@ static int criu_get_process_object_info(struct kfd_process *p,
>
> num_events = kfd_get_num_events(p);
>
> - ret = svm_range_get_info(p, &num_svm_ranges, &svm_priv_data_size);
> - if (ret)
> - return ret;
> + svm_range_get_info(p, &num_svm_ranges, &svm_priv_data_size);
>
> *num_objects = num_queues + num_events + num_svm_ranges;
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 100717a98ec1..ebdbbb620b11 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -4076,8 +4076,8 @@ int kfd_criu_restore_svm(struct kfd_process *p,
> return ret;
> }
>
> -int svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
> - uint64_t *svm_priv_data_size)
> +void svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
> + uint64_t *svm_priv_data_size)
> {
> uint64_t total_size, accessibility_size, common_attr_size;
> int nattr_common = 4, nattr_accessibility = 1;
> @@ -4089,8 +4089,6 @@ int svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
> *svm_priv_data_size = 0;
>
> svms = &p->svms;
> - if (!svms)
> - return -EINVAL;
>
> mutex_lock(&svms->lock);
> list_for_each_entry(prange, &svms->list, list) {
> @@ -4132,7 +4130,6 @@ int svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
>
> pr_debug("num_svm_ranges %u total_priv_size %llu\n", *num_svm_ranges,
> *svm_priv_data_size);
> - return 0;
> }
>
> int kfd_criu_checkpoint_svm(struct kfd_process *p,
> @@ -4149,8 +4146,6 @@ int kfd_criu_checkpoint_svm(struct kfd_process *p,
> struct mm_struct *mm;
>
> svms = &p->svms;
> - if (!svms)
> - return -EINVAL;
>
> mm = get_task_mm(p->lead_thread);
> if (!mm) {
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.h b/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
> index 6ea23c78009c..01c7a4877904 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.h
> @@ -184,8 +184,8 @@ void schedule_deferred_list_work(struct svm_range_list *svms);
> void svm_range_dma_unmap_dev(struct device *dev, dma_addr_t *dma_addr,
> unsigned long offset, unsigned long npages);
> void svm_range_dma_unmap(struct svm_range *prange);
> -int svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
> - uint64_t *svm_priv_data_size);
> +void svm_range_get_info(struct kfd_process *p, uint32_t *num_svm_ranges,
> + uint64_t *svm_priv_data_size);
> int kfd_criu_checkpoint_svm(struct kfd_process *p,
> uint8_t __user *user_priv_data,
> uint64_t *priv_offset);
> @@ -237,13 +237,12 @@ static inline int svm_range_schedule_evict_svm_bo(
> return -EINVAL;
> }
>
> -static inline int svm_range_get_info(struct kfd_process *p,
> - uint32_t *num_svm_ranges,
> - uint64_t *svm_priv_data_size)
> +static inline void svm_range_get_info(struct kfd_process *p,
> + uint32_t *num_svm_ranges,
> + uint64_t *svm_priv_data_size)
> {
> *num_svm_ranges = 0;
> *svm_priv_data_size = 0;
> - return 0;
> }
>
> static inline int kfd_criu_checkpoint_svm(struct kfd_process *p,
prev parent reply other threads:[~2025-05-16 18:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 14:12 Ваторопин Андрей
2025-05-16 18:35 ` Felix Kuehling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9cabe07-09cc-49a9-8311-6795695c28f6@amd.com \
--to=felix.kuehling@amd.com \
--cc=a.vatoropin@crpt.ru \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®