From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D40394EBA for ; Mon, 1 Jun 2026 11:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312202; cv=none; b=iZ6q7RWpEtJPsPq2hyAsLNWaBsBApN6nAlALIUwayZjAAYSpfsRTraLG/eeX9nwZKb4BuBwgieYjP0WnRCGbCfOQiaiT6q4Z55E0hToPTXwavwdHWGJlsxcUu/evsNPT0FCxX8+IN4L+jvAiR7FmsKJ5L0wBzD72GFWiraRHbXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780312202; c=relaxed/simple; bh=fHxsazB7z+nu0WXVW1TygTZl47qa2PMlJrC6QSq/Hvg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qiRZLUURGGo0RVnzfWd+YE+WQbHf/8Gc6Id+fmSFUnOHXN2VD3mm9hqZOVzuImnKnF4pofprAQAcp/AbWUWGL1Yv8sJwqhETnkApt4pssUq/z0BTjQ2gTVvAGfnv1sXkuL8teJrWzyBNv4ZnoQVGZx1DH9QtZ9W6BhfqZNaDhks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=fwuYrdm1; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="fwuYrdm1" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780312189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TTr4tQwBByNMsxp8D3ocf5yh1cG3xPQPohe/Uv/Q2R4=; b=fwuYrdm12vhes1RUcQfe5De52w6tNFQ4WjqITT2oAJkvclwo0eQiv9oCvrJTOzfOdF8EjN pUt+rMTOaFp6fdp8WsZ2kzw7Yw6so77nPChFnq5PyPwRn8wgss95ANbm+qnIdMMjsuLu27 ToMkL/pgiC9lFr1RSqNcPITzxAXrMA8= Date: Mon, 1 Jun 2026 19:09:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v5 9/9] mm: switch deferred split shrinker to list_lru Content-Language: en-US To: hannes@cmpxchg.org Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, shakeel.butt@linux.dev, mhocko@kernel.org, david@fromorbit.com, roman.gushchin@linux.dev, muchun.song@linux.dev, qi.zheng@linux.dev, yosry.ahmed@linux.dev, ziy@nvidia.com, liam@infradead.org, usama.arif@linux.dev, kas@kernel.org, vbabka@kernel.org, ryncsn@gmail.com, zaslonko@linux.ibm.com, gor@linux.ibm.com, baolin.wang@linux.alibaba.com, baohua@kernel.org, dev.jain@arm.com, npache@redhat.com, ryan.roberts@arm.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260527204757.2544958-10-hannes@cmpxchg.org> <20260601103947.63923-1-lance.yang@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: <20260601103947.63923-1-lance.yang@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2026/6/1 18:39, Lance Yang wrote: > > On Wed, May 27, 2026 at 04:45:16PM -0400, Johannes Weiner wrote: > [...] >> diff --git a/mm/memory.c b/mm/memory.c >> index 135f5c0f57bd..f22e61d8c8de 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -5222,6 +5222,10 @@ static struct folio *alloc_anon_folio(struct vm_fault *vmf) >> folio_put(folio); >> goto next; >> } >> + if (order > 1 && folio_memcg_alloc_deferred(folio)) { >> + folio_put(folio); > > Missing a MTHP_STAT_ANON_FAULT_FALLBACK bump here? > > Since we jump straight to fallback and end up at order-0 :) Sorry for the noise, I missed the earlier discussion. Never mind this one, please. > >> + goto fallback; >> + } >> folio_throttle_swaprate(folio, gfp); >> /* >> * When a folio is not zeroed during allocation > [...] > > Cheers, Lance