Hi Lorenzo, On 04/02/21 3:28 pm, Lorenzo Pieralisi wrote: > On Tue, Feb 02, 2021 at 12:12:55PM -0800, Randy Dunlap wrote: >> The pci-epf-ntb driver uses configfs APIs, so it should depend on >> CONFIGFS_FS to prevent build errors. >> >> ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs': >> pci-epf-ntb.c:(.text+0x1b): undefined reference to `config_group_init_type_name' >> >> Fixes: 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality") >> >> Signed-off-by: Randy Dunlap >> Cc: Kishon Vijay Abraham I >> Cc: Lorenzo Pieralisi >> Cc: linux-pci@vger.kernel.org >> --- >> You may switch to 'select CONFIG_FS_FS' if you feel strongly about it. > > Kishon ? There seems to be some issue in the version that got merged. The v11 patch series had this fixed [1] by using select CONFIGFS_FS. However whatever was merged seems to be v10 which didn't have select CONFIGFS_FS [2]. I had sent a private mail to you pointing the same (attached for reference, not sure if it was delivered). Thanks Kishon [1] -> https://lore.kernel.org/linux-doc/20210201195809.7342-14-kishon@ti.com/ [2] -> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/pci/endpoint/functions/Kconfig > > Thanks, > Lorenzo > >> drivers/pci/endpoint/functions/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20210202.orig/drivers/pci/endpoint/functions/Kconfig >> +++ linux-next-20210202/drivers/pci/endpoint/functions/Kconfig >> @@ -16,6 +16,7 @@ config PCI_EPF_TEST >> config PCI_EPF_NTB >> tristate "PCI Endpoint NTB driver" >> depends on PCI_ENDPOINT >> + depends on CONFIGFS_FS >> help >> Select this configuration option to enable the NTB driver >> for PCI Endpoint. NTB driver implements NTB controller