From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17FEC23D29F for ; Tue, 25 Nov 2025 14:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764080280; cv=none; b=V/jNL8SuIFwnSm3/lssvG/t/BYVCqin3UYDz1BJekyy1g8dBeAdf0ZMBPiyF1xWVQwmcWWCjdsTv9x/3J2G0BzfaQdkcyt4ZcQSOHTJsrBWa8yi+oF6Ac/+g05zyKnp2Lr7bcYBOMYdwsfjFRNxKwyNOeMzIt+eQe3rqUAI01Xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764080280; c=relaxed/simple; bh=2Ur0OJdRZLxQxQ7Ppyeg130nQxzLy00N2xieou1E18U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EQIvrJhoR5bOPeWO6hJuxsFdDdd876qbmYicnEuG5/Gn6iyvjz29JDFEZAthy4VMhHj4TZwZBfli0vKppEITgx4EzTkH9w9zGghvxsbBh9BL/A1Qm7nqEbRpb6c1TSqSunHkerIDb8ddu2X7ZnUQmGe1nDN7xVVpJDhHS4HpGB4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ap5kYhL0; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=KjOqHMOh; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ap5kYhL0"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="KjOqHMOh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764080278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FSwJ5fwmRDxewMfNoKhcg97Z3bqu6PXdkjiIvWnFQ9Y=; b=ap5kYhL0P7y7uusVIMyTjXiT/lh+174QFDEYS8TzsLgtfKyMSlfNnRzqPpr46xrf/MfCIi +tfXVT7QT1BaPi+NICdKbBSr41UxT0yljqTLNzHo1CMYW93Wl9nEEf0fsZKqO3JaMA6wHe WQ4oJej7+W1cUdJuM9BO5IdkM+WSZ0I= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-5iSaIPfQMGCf7YIO8bmk-w-1; Tue, 25 Nov 2025 09:17:56 -0500 X-MC-Unique: 5iSaIPfQMGCf7YIO8bmk-w-1 X-Mimecast-MFC-AGG-ID: 5iSaIPfQMGCf7YIO8bmk-w_1764080274 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-b736eca894fso449529466b.1 for ; Tue, 25 Nov 2025 06:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1764080274; x=1764685074; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FSwJ5fwmRDxewMfNoKhcg97Z3bqu6PXdkjiIvWnFQ9Y=; b=KjOqHMOhkwn0uw0rkWPfTWbEuXImU+ltd5lgURdSdTgO7OC92tLS4D6Z1Dui9Gukq8 yI00TVFZenRGRtMG67Pj2i2ASbWMCqTzAHCGXN7OJumFQQlsm1rReEsTt4e/3ObXe4CS a0QzS8dD9rkISJ9jcSrpdxz/fS5tObG1bR9HpmlwEypVkFN2zH+R84aeaOdrjstlvX45 5mqpNbdVqjXzaxSZMkmo/uYlC9QLoRB3alXwuGCyz5qIzn5phU7wziJIriDpaSH1o8sp SczC7BxWTqMB38XZKpX6C1mFHDY8xOpkIZjusa5UNplSNSwUF1T33l5+1F0/0n5iMdz0 /tzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764080274; x=1764685074; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FSwJ5fwmRDxewMfNoKhcg97Z3bqu6PXdkjiIvWnFQ9Y=; b=JUyi8HTLNomvPsC6PQGIu0ltOywI2L6TJyyrSd6FRCRno49AnpwpNqV3XOuyWFUdHC PZaXmBCtY7jPPRAHvrHtAwLSu8raVjRTRRYYvCMh9YV1p6tk/vvTNdqJRkM9oJhNfebO AmO468hy5eIQCU+axg/p59XOmPjHtkPFYh65Q+hZQTT0uWyi+I382v82cEcV4fK1Pj60 0x1BAsIRe+aBEPSUJMTEXMFRLAxu+z5B6Qtqc0y4SGfu5CHJMp24KhLQRwXwO9HX4y2U 7vidkhxtthNhqtGxzQDeHkMpgVYGjbqNe3G9Lv3PjrIjhDLnfmfrx/KmmoqP2w3M5Mrf PgpA== X-Forwarded-Encrypted: i=1; AJvYcCWIenWmLOCW0LbB9GnHbkT9NpvzuAYKoxh2qaQsOaf+HFsDloMyK779UCFt6ruWdKM4/FBDvMBae6W/WcU=@vger.kernel.org X-Gm-Message-State: AOJu0YwTdHGlrrZf4Dj3mYRLByQ48K7VtAbpPpKW9pRLT0XJLULaYAFu I5uDbJ+4y/BR+E7hZ1f/G7gbh0iv3iC3+8AC47NuzOLRJjWrx/pYqZygIqaMhYhDXSF/MTpkjUG yfw0V/QvQKm/8UvBJ86bEr2p/JRqcXwpUWHQpZzyl9Acy/XDdOVL7H8g7/TL0E6vSxQ== X-Gm-Gg: ASbGnct9CEKHQj+OKFy7IW95Zqn8ck/Nq53R2R6J3zDctr23AGJbuYMLDNeTK09uqbg BplZ7BM6rSjn9HlJiMzPCQAFM4mMp7izcOezfSt4qoXnTAmtmWMvL4+jRGwhi+mEKuDI0380xA7 1fwqIyMT1gXkXrNTPt0hPHkG6ToOBHJdHsibb6gciHtxJmJ1LPLeWERo9mS1JdcFob6iItpYhdF 4lcmWaSpa76SnwuVcTot4/BqatOrpefVWFtsOS2JCrHCOFbzsoW3ewipqj9thCIiUcpSg5x7gma PgDIYl7lutiiSlq4GbvS6713Jm27XyMZSlKXR8qR7KkSotUTZnrbAW+U/7uJmwDvJ3KOrWEgIZK unyhG9VXDNSHHdg== X-Received: by 2002:a17:906:ee8c:b0:b73:572d:3b07 with SMTP id a640c23a62f3a-b767170ccb3mr1838887666b.28.1764080274466; Tue, 25 Nov 2025 06:17:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IFsrmrV2cBWDr+ZSzNL9o2G3mEYj/CXK8Uil/l4NJOy/CwceejmUKWQCZ9oPoMhj102mNMv9w== X-Received: by 2002:a17:906:ee8c:b0:b73:572d:3b07 with SMTP id a640c23a62f3a-b767170ccb3mr1838881166b.28.1764080273904; Tue, 25 Nov 2025 06:17:53 -0800 (PST) Received: from [192.168.88.32] ([212.105.153.231]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654cf0435sm1599810766b.4.2025.11.25.06.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 06:17:53 -0800 (PST) Message-ID: Date: Tue, 25 Nov 2025 15:17:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 06/12] ipvlan: Take addr_lock in ipvlan_open() To: Dmitry Skorodumov , netdev@vger.kernel.org, Jakub Kicinski , Xiao Liang , Kuniyuki Iwashima , Stanislav Fomichev , Etienne Champetier , linux-kernel@vger.kernel.org Cc: andrey.bokhanko@huawei.com, edumazet@google.com, Andrew Lunn , "David S. Miller" References: <20251120174949.3827500-1-skorodumov.dmitry@huawei.com> <20251120174949.3827500-7-skorodumov.dmitry@huawei.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251120174949.3827500-7-skorodumov.dmitry@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/20/25 6:49 PM, Dmitry Skorodumov wrote: > It was forgotten to lock addrs in ipvlan_open(). > > Seems that code was initially written in assumption > that any address change occurs under rtnl_lock(). But > it's not true for the ipv6 case. So, we have to > take addr_lock in ipvlan_open(). > > Signed-off-by: Dmitry Skorodumov ... same here. This looks like 'net' material and need a fixes tag. /P