mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxim Levitsky <mlevitsk@redhat.com>
To: kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Sean Christopherson <seanjc@google.com>
Subject: vmx_pmu_caps_test fails on Skylake based CPUS due to read only LBRs
Date: Fri, 18 Oct 2024 20:48:45 -0400	[thread overview]
Message-ID: <c9d8269bff69f6359731d758e3b1135dedd7cc61.camel@redhat.com> (raw)

Hi,

Our CI found another issue, this time with vmx_pmu_caps_test.

On 'Intel(R) Xeon(R) Gold 6328HL CPU' I see that all LBR msrs (from/to and TOS),
are always read only - even when LBR is disabled - once I disable the feature in DEBUG_CTL,
all LBR msrs reset to 0, and you can't change their value manually.
Freeze LBRS on PMI seems not to affect this behavior.

I don't know if this is how the hardware is supposed to work (Intel's manual doesn't mention anything about this), 
or if it is something platform specific, because this system also was found to have LBRs enabled 
(IA32_DEBUGCTL.LBR == 1) after a fresh boot, as if BIOS left them enabled - I don't have an idea on why.

The problem is that vmx_pmu_caps_test writes 0 to LBR_TOS via KVM_SET_MSRS, and KVM actually passes this write to
actual hardware msr (this is somewhat wierd), and since the MSR is not writable and silently drops writes instead,
once the test tries to read it, it gets some random value instead.

Any advice?

Best regards,
	Maxim Levitsky



             reply	other threads:[~2024-10-19  0:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-19  0:48 Maxim Levitsky [this message]
2024-10-28 15:55 ` Sean Christopherson
2024-11-03 23:32   ` Maxim Levitsky
2024-11-22  3:35     ` Maxim Levitsky
2024-12-14  0:20       ` Maxim Levitsky
2025-01-21 22:56         ` Maxim Levitsky
2025-01-22  1:02     ` Sean Christopherson
2025-01-22 16:36       ` Maxim Levitsky
2025-01-22 21:02         ` Sean Christopherson
2025-01-24 23:36           ` Maxim Levitsky
2025-01-25  0:12             ` Sean Christopherson
2025-01-27 17:58               ` Maxim Levitsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9d8269bff69f6359731d758e3b1135dedd7cc61.camel@redhat.com \
    --to=mlevitsk@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®