From: "Arnd Bergmann" <arnd@arndb.de>
To: "Bartosz Golaszewski" <brgl@bgdev.pl>, "Arnd Bergmann" <arnd@kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Peng Fan" <peng.fan@nxp.com>, "Lee Jones" <lee@kernel.org>,
"Koichiro Den" <koichiro.den@canonical.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: make legacy interfaces optional
Date: Thu, 24 Jul 2025 16:22:23 +0200 [thread overview]
Message-ID: <c9d9eeca-b62a-4105-b65c-bf78158c42df@app.fastmail.com> (raw)
In-Reply-To: <CAMRc=Mejnr8UzN93X=CWcV5jDTt9-U+Nxcm3qb=6uVV0PMiZVQ@mail.gmail.com>
On Wed, Jul 23, 2025, at 10:39, Bartosz Golaszewski wrote:
> On Tue, Jul 22, 2025 at 5:36 PM Arnd Bergmann <arnd@kernel.org> wrote:
>> #include <linux/types.h>
>> +#ifdef CONFIG_GPIOLIB
>> +#include <linux/gpio/consumer.h>
>
> I want to queue this ASAP but do we really need this guard here?
> consumer.h already guards against !CONFIG_GPIOLIB internally, right?
I was trying to not change the behavior here. linux/gpio/consumer.h has
an #ifdef check but has the #else portion with empty stubs that can
be used by any driver that includes it, while drivers that include
linux/gpio.h never saw the stub version.
Arnd
next prev parent reply other threads:[~2025-07-24 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 15:35 Arnd Bergmann
2025-07-22 16:27 ` Alexander Sverdlin
2025-07-23 8:39 ` Bartosz Golaszewski
2025-07-23 14:17 ` Andy Shevchenko
2025-07-24 14:36 ` Arnd Bergmann
2025-07-24 14:22 ` Arnd Bergmann [this message]
2025-07-24 14:24 ` Bartosz Golaszewski
2025-07-23 14:15 ` Andy Shevchenko
2025-07-24 14:25 ` (subset) " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9d9eeca-b62a-4105-b65c-bf78158c42df@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexander.sverdlin@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=geert+renesas@glider.be \
--cc=koichiro.den@canonical.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®