From: netdev@kapio-technology.com
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Ido Schimmel <idosch@idosch.org>,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation
Date: Thu, 08 Dec 2022 15:41:24 +0100 [thread overview]
Message-ID: <c9dc3682dd9e4c2a9d81a7df0f3f9124@kapio-technology.com> (raw)
In-Reply-To: <20221208133524.uiqt3vwecrketc5y@skbuf>
On 2022-12-08 14:35, Vladimir Oltean wrote:
> On Thu, Dec 08, 2022 at 01:28:27PM +0100, netdev@kapio-technology.com
> wrote:
>> On 2022-12-07 21:29, Vladimir Oltean wrote:
>> > On Tue, Dec 06, 2022 at 05:36:42PM +0100, netdev@kapio-technology.com wrote:
>> > > > I was under the impression that we agreed that the locking change will
>> > > > be split to a separate patch.
>> > >
>> > > Sorry, I guess that because of the quite long time that has passed as I
>> > > needed to get this FID=0 issue sorted out, and had many other different
>> > > changes to attend, I forgot.
>> >
>> > Well, at least you got the FID=0 issue sorted out... right?
>> > What was the cause, what is the solution?
>>
>> Well I got it sorted out in the way that I have identified that it is
>> the
>> ATU op that fails some times. I don't think there is anything that can
>> be
>> done about that, other than what I do and let the interrupt routing
>> return
>> an error.
>
> Yikes. But why would you call that "sorted out", though? Just to make
> it
> appear as though you really spent some time on it, and use it as an
> excuse for something else?
>
>> it is the ATU op that fails some times.
>
> Let's start with the assumption that this is correct. A person with
> critical thinking will ask "can I prove that it is?".
>
> If the ATU operation fails sometimes, I would expect that it always
> fails in the same way, by returning FID 0, where 0 is some kind of
> "invalid" value.
>
> But if FID 0 is actually FID_STANDALONE, then you'd read FID_STANDALONE
> even if you change the value of FID_STANDALONE in the driver to
> something else, like 1.
>
> Something ultra hackish like this will install VLAN 3050 as first VID
> in
> the switch, and that will gain FID 0. Then, MV886XXX_VID_STANDALONE
> will
> gain FID 1. So we need to adjust the definitions.
>
Here is an example of the output I have when running the
locked_port_mab() under the selftests...
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6xxx_g1_atu_prob_irq_thread_fn: 13 callbacks suppressed
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
the -22 errors are all when it returns FID=0, and it is the same mac all
the way.
I have other logs, where the -22 occurs at random other times, f.ex.
same test:
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6xxx_g1_atu_prob_irq_thread_fn: 4 callbacks suppressed
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU miss violation for
8e:a9:fc:14:58:06 portvec 0 spid 2
mv88e6085 1002b000.ethernet-1:04: ATU problem: error -22 while handling
interrupt
What else conclusion than it is the ATU op that fails?
next prev parent reply other threads:[~2022-12-08 14:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 18:59 [PATCH net-next 0/3] mv88e6xxx: Add MAB offload support Hans J. Schultz
2022-12-05 18:59 ` [PATCH net-next 1/3] net: dsa: mv88e6xxx: allow reading FID when handling ATU violations Hans J. Schultz
2022-12-05 18:59 ` [PATCH net-next 2/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags Hans J. Schultz
2022-12-06 12:30 ` Ido Schimmel
2022-12-05 18:59 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans J. Schultz
2022-12-06 12:53 ` Ido Schimmel
2022-12-06 16:36 ` netdev
2022-12-07 20:29 ` Vladimir Oltean
2022-12-08 12:28 ` netdev
2022-12-08 13:35 ` Vladimir Oltean
2022-12-08 14:41 ` netdev [this message]
2022-12-08 14:43 ` Vladimir Oltean
2022-12-08 16:03 ` netdev
2022-12-08 16:09 ` Vladimir Oltean
-- strict thread matches above, loose matches on Subject: below --
2022-03-10 14:23 [PATCH net-next 0/3] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) Hans Schultz
2022-03-10 14:23 ` [PATCH net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans Schultz
2022-03-10 14:28 ` Vladimir Oltean
2022-03-10 15:00 ` Hans Schultz
2022-03-10 15:07 ` Vladimir Oltean
2022-03-10 15:51 ` Hans Schultz
2022-03-10 16:05 ` Vladimir Oltean
2022-03-10 16:40 ` Hans Schultz
2022-03-10 15:57 ` Hans Schultz
2022-03-14 10:46 ` Hans Schultz
2022-03-16 23:34 ` Vladimir Oltean
2022-03-17 8:52 ` Hans Schultz
2022-03-17 14:19 ` Andrew Lunn
2022-03-17 15:36 ` Vladimir Oltean
2022-03-17 16:07 ` Hans Schultz
2022-03-17 16:18 ` Vladimir Oltean
2022-03-17 16:58 ` Hans Schultz
2022-03-17 17:20 ` Vladimir Oltean
2022-03-18 10:04 ` Hans Schultz
2022-03-18 12:14 ` Vladimir Oltean
2022-03-18 13:10 ` Hans Schultz
2022-03-18 13:19 ` Vladimir Oltean
2022-03-22 11:01 ` Hans Schultz
2022-03-22 11:08 ` Vladimir Oltean
2022-03-22 13:21 ` Hans Schultz
2022-03-22 14:47 ` Hans Schultz
2022-03-23 10:13 ` Hans Schultz
2022-03-23 10:16 ` Vladimir Oltean
2022-03-23 10:46 ` Hans Schultz
2022-03-23 10:57 ` Hans Schultz
2022-03-23 11:21 ` Vladimir Oltean
2022-03-23 11:43 ` Hans Schultz
2022-03-23 11:54 ` Vladimir Oltean
2022-03-21 14:51 ` Hans Schultz
2022-03-10 14:54 ` Andrew Lunn
2022-03-11 7:59 ` Hans Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9dc3682dd9e4c2a9d81a7df0f3f9124@kapio-technology.com \
--to=netdev@kapio-technology.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®