From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA2251BDA98 for ; Tue, 1 Oct 2024 07:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727769397; cv=none; b=ZrMj/qVqm5JUZ3oP0EuoR/UNyZVhtJZxdsE3+62FuhuoZ8S02w9EJ0Dt2eCuCRfCCirzvC6UopBP0lTjZ3HTXGKNF1+dfVESc8ue+EpMwedFZrxgD+g/5ROS+oRt/SB5QIoUNfmTRDHYAFiI7u1LqXPHRqDidFQkDj7dz5nUyn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727769397; c=relaxed/simple; bh=Ua1+B8Tp8YLtkN1MN/+mYFNVPWPWimun8c+D3yIAJuo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JfIeU53WV7CZ5yivLbJFek2jdSah/JkGth+go1/vVMkZ+jsQqHLZAYm4kUj7aFfOGxAMOl5K+YjToqrrQ2kR1gWWNpr3od4XYzzSuMh+k86XzQ6GesxfagPq256NhnsDGtQCZxKV7nanOxJD0eemnMuM1w/eHfNYMP75AaPz/ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Qkwl/YS6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Qkwl/YS6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727769394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cbH8XpzflwSTa9FMVre7AgUkuPu4oSVgTfzk1ypDcwE=; b=Qkwl/YS6OJAlP+EhVm9lC4e78mHA7VvPveGzfgsfrsErI49CiLFWEDyFi45vIDXXxy/7jf 6oUEFTTvgUqgvad8pmHR9/4/zoEsZuQZBUllqa/tuNGlNJEBqEKn0dR2SdKUg3cAX2dtlo pmQiitOmlJ/TQwdT8QMbSHOSWrr3ows= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-sLyYgVjpNX6D_fm8-J4KJA-1; Tue, 01 Oct 2024 03:56:33 -0400 X-MC-Unique: sLyYgVjpNX6D_fm8-J4KJA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42cbcf60722so41048035e9.1 for ; Tue, 01 Oct 2024 00:56:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727769392; x=1728374192; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cbH8XpzflwSTa9FMVre7AgUkuPu4oSVgTfzk1ypDcwE=; b=OUTgqVuyHltgi2DGAz/9TVXWPK7loDZ8q++SEORbAB4eD6l+fJOFPxhwhgVTVTMwuQ I3lppDmeb+8ZYEhm+5QaUyExG/BTUndWGJWJq9P3yzHn6q6xKjADAjkMKIdS8UF/rw02 2+oKNJPrne8gZAY6/bR1JPe3O/M3zgdYcS7BAP15OqziwUk0kyNVmq666ffkPeNazsHF yjzgDCLNSAX/yMeIdW7Yol9qUfZd1T9AuGoJ4O+6wPvT29rKlG0XkPtWtbWDyHK7yNqf wRQfHdxxSvx+NSPaPljlTOItX64BUuQeMJC0/6KPj6MxfUUl9Fo/Iv2F5TSGENXX5+f6 mgBQ== X-Forwarded-Encrypted: i=1; AJvYcCUbrBHBhZfY/JFNFQp0163dp8Ydr0P64KEyrcNQhNONyOLLvpVEONaQ7zdIRkOhTG0g9Kqznpf+xSqcJ9Q=@vger.kernel.org X-Gm-Message-State: AOJu0YytDSBG23cWJATsUe0Nr8Uju1pOVTZmzjmFdWLZcsYcsy7Kwi1n 4MudCspfbKO/iK832WFLsy7L+j10ufgW+jB0QJa9sYUxw5431Or6fr6gZFPRFTR0M4fTf3klyH4 mlNmtldQRF20isfVRGYQ+x5OpcZ6z3M4dQjsqS4EAkmYyYeNZcAv0vt3tzLyE3w== X-Received: by 2002:a05:600c:5254:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-42f584347a3mr116624805e9.14.1727769392452; Tue, 01 Oct 2024 00:56:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQhqmU2cWYjY+tEC5W3ihB5hcxwnPWrPcZ+Vwc2MHQ3nR+ln898OKJE10BR5q9novtPOP9GQ== X-Received: by 2002:a05:600c:5254:b0:42e:93af:61c5 with SMTP id 5b1f17b1804b1-42f584347a3mr116624545e9.14.1727769391966; Tue, 01 Oct 2024 00:56:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c733:a800:ea78:e754:1995:5390? (p200300cbc733a800ea78e75419955390.dip0.t-ipconnect.de. [2003:cb:c733:a800:ea78:e754:1995:5390]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e969ffb11sm173758395e9.21.2024.10.01.00.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 00:56:30 -0700 (PDT) Message-ID: Date: Tue, 1 Oct 2024 09:56:29 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tdx, memory hotplug: Check whole hot-adding memory range for TDX To: Dan Williams , Huang Ying , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Kirill A . Shutemov" Cc: x86@kernel.org, Andrew Morton , Oscar Salvador , linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kai Huang , "H. Peter Anvin" , Andy Lutomirski References: <20240930055112.344206-1-ying.huang@intel.com> <66fb9a89dd814_964fe294ed@dwillia2-xfh.jf.intel.com.notmuch> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <66fb9a89dd814_964fe294ed@dwillia2-xfh.jf.intel.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.10.24 08:45, Dan Williams wrote: > David Hildenbrand wrote: >> On 30.09.24 07:51, Huang Ying wrote: >>> On systems with TDX (Trust Domain eXtensions) enabled, memory ranges >>> hot-added must be checked for compatibility by TDX. This is currently >>> implemented through memory hotplug notifiers for each memory_block. >>> If a memory range which isn't TDX compatible is hot-added, for >>> example, some CXL memory, the command line as follows, >>> >>> $ echo 1 > /sys/devices/system/node/nodeX/memoryY/online >>> >>> will report something like, >>> >>> bash: echo: write error: Operation not permitted >>> >>> If pr_debug() is enabled, the error message like below will be shown >>> in the kernel log, >>> >>> online_pages [mem 0xXXXXXXXXXX-0xXXXXXXXXXX] failed >>> >>> Both are too general to root cause the problem. This will confuse >>> users. One solution is to print some error messages in the TDX memory >>> hotplug notifier. However, memory hotplug notifiers are called for >>> each memory block, so this may lead to a large volume of messages in >>> the kernel log if a large number of memory blocks are onlined with a >>> script or automatically. For example, the typical size of memory >>> block is 128MB on x86_64, when online 64GB CXL memory, 512 messages >>> will be logged. >> >> ratelimiting would likely help here a lot, but I agree that it is >> suboptimal. >> >>> >>> Therefore, in this patch, the whole hot-adding memory range is checked >>> for TDX compatibility through a newly added architecture specific >>> function (arch_check_hotplug_memory_range()). If rejected, the memory >>> hot-adding will be aborted with a proper kernel log message. Which >>> looks like something as below, >>> >>> virt/tdx: Reject hot-adding memory range: 0xXXXXXXXX-0xXXXXXXXX for TDX compatibility. >> > > The target use case is to support CXL memory on TDX enabled systems. >>> If the CXL memory isn't compatible with TDX, the whole CXL memory >>> range hot-adding will be rejected. While the CXL memory can still be >>> used via devdax interface. >> >> I'm curious, why can that memory be used through devdax but not through >> the buddy? I'm probably missing something important :) > > TDX requires memory that supports integrity and encryption. Until > platforms and expanders with a technology called CXL TSP arrives, CXL > memory is not able to join the TCB. > > The TDX code for simplicity assumes that only memory present at boot > might be capable of TDX and that everything else is not. So is there ever a chance where add_memory() would actually work now with TDX? Or can we just simplify and unconditionally reject add_memory() if TDX is enabled? > > Confidential VMs use guest_mem_fd to allocate memory, and that only > pulls from the page allocator as a backend. > > This ability to use devdax in an offline mode is a hack to not Thanks, I was missing the "hack" of it, and somehow (once again) assumed that we would be hotplugging memory into confidential VMs. -- Cheers, David / dhildenb