From: Thomas Zimmermann <tzimmermann@suse.de>
To: Colin King <colin.king@canonical.com>,
Dave Airlie <airlied@redhat.com>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] drm/mgag200: make a const array static, makes object smaller
Date: Fri, 5 Feb 2021 15:43:44 +0100 [thread overview]
Message-ID: <c9dd8c05-93cf-f74c-48a0-e512f2e2ed9b@suse.de> (raw)
In-Reply-To: <20210204191156.110778-1-colin.king@canonical.com>
[-- Attachment #1.1: Type: text/plain, Size: 1840 bytes --]
Merged.
Am 04.02.21 um 20:11 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the const array m_div_val on the stack but instead make
> it static. Makes the object code smaller by 29 bytes:
>
> Before:
> text data bss dec hex filename
> 34736 4552 0 39288 9978 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> After:
> text data bss dec hex filename
> 34625 4616 0 39241 9949 drivers/gpu/drm/mgag200/mgag200_mode.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>
> V2: move static declaration to the top of the declarations
>
> ---
> drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 1dfc42170059..c3dfde8cad25 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -706,13 +706,13 @@ static int mga_g200eh_set_plls(struct mga_device *mdev, long clock)
>
> static int mga_g200er_set_plls(struct mga_device *mdev, long clock)
> {
> + static const unsigned int m_div_val[] = { 1, 2, 4, 8 };
> unsigned int vcomax, vcomin, pllreffreq;
> unsigned int delta, tmpdelta;
> int testr, testn, testm, testo;
> unsigned int p, m, n;
> unsigned int computed, vco;
> int tmp;
> - const unsigned int m_div_val[] = { 1, 2, 4, 8 };
>
> m = n = p = 0;
> vcomax = 1488000;
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2021-02-05 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 19:11 Colin King
2021-02-05 14:43 ` Thomas Zimmermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9dd8c05-93cf-f74c-48a0-e512f2e2ed9b@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=colin.king@canonical.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®