From: Randy Dunlap <rdunlap@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-mmc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [GIT PULL] MMC fixes for v5.15-rc8
Date: Fri, 29 Oct 2021 14:47:24 -0700 [thread overview]
Message-ID: <c9deee06-dd78-22fc-2d93-7c70e1f6522b@infradead.org> (raw)
In-Reply-To: <CAHk-=wgQLtvDh-3zhGNCWNAssubDxgxC+7RdEmHBmK_84rLT2Q@mail.gmail.com>
On 10/29/21 11:04 AM, Linus Torvalds wrote:
> On Fri, Oct 29, 2021 at 5:07 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>>
>> - winbond: Silences build errors on M68K
>
> I think this one is wrong.
>
> I think the problem is that m68k declares "claim_dma_lock()" in the
> wrong header file. It's in <asm/floppy.h> instead of <asm/dma.h>
>
> I'm somewhat surprised that this doesn't hit m68k in other places -
> there are other drivers that use that same ISA DMA interface.
I moved claim_dma_lock() and release_dma_lock() fro asm/floppy.h
to asm/dma.h (for arch/m68k/). I spent a few hours trying to fix
the resulting fallout. Guess I'm just slow.
FWIW, the biggest problem I had was the variety of types of DMA that
M68K supports (once a driver includes <asm/dma.h>, things get messy).
> I've pulled this, but I hate how random that fix is.
--
~Randy
next prev parent reply other threads:[~2021-10-29 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 12:07 Ulf Hansson
2021-10-29 18:04 ` Linus Torvalds
2021-10-29 21:47 ` Randy Dunlap [this message]
2021-10-29 18:49 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9deee06-dd78-22fc-2d93-7c70e1f6522b@infradead.org \
--to=rdunlap@infradead.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mmc@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®