From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751265AbeAVUqP (ORCPT ); Mon, 22 Jan 2018 15:46:15 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:44400 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbeAVUqM (ORCPT ); Mon, 22 Jan 2018 15:46:12 -0500 X-Google-Smtp-Source: AH8x226XVxiRE/iTG/7QtGDJ4N3MIAA7osbfrNkgriumviSDUOT3EsXVqi5DoToAuKt0HePCD9sTWQ== Subject: Re: [PATCH net-next v2] net: core: Expose number of link up/down transitions To: David Miller Cc: netdev@vger.kernel.org, dsahern@gmail.com, jiri@resnulli.us, cphealy@gmail.com, andrew@lunn.ch, jakub.kicinski@netronome.com, decot@googlers.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, daniel@iogearbox.net, nikolay@cumulusnetworks.com, ast@fb.com, roopa@cumulusnetworks.com, vyasevich@gmail.com, jonas@southpole.se, maheshb@google.com, stephen@networkplumber.org, ishkamiel@gmail.com, fw@strlen.de, arvind.yadav.cs@gmail.com, avagin@openvz.org, mingo@kernel.org, lucien.xin@gmail.com, mschiffer@universe-factory.net, jbenc@redhat.com, linux-kernel@vger.kernel.org References: <20180118175921.17645-1-f.fainelli@gmail.com> <20180122.154318.784941022568373440.davem@davemloft.net> From: Florian Fainelli Message-ID: Date: Mon, 22 Jan 2018 12:46:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20180122.154318.784941022568373440.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2018 12:43 PM, David Miller wrote: > From: Florian Fainelli > Date: Thu, 18 Jan 2018 09:59:13 -0800 > >> From: David Decotigny >> >> Expose the number of times the link has been going UP or DOWN, and >> update the "carrier_changes" counter to be the sum of these two events. >> While at it, also update the sysfs-class-net documentation to cover: >> carrier_changes (3.15), carrier_up_count (4.16) and carrier_down_count >> (4.16) >> >> Signed-off-by: David Decotigny >> [Florian: >> * rebase >> * add documentation >> * merge carrier_changes with up/down counters] >> Signed-off-by: Florian Fainelli >> --- >> Changes in v2: >> - fixed sysfs attributes to use >> - renamed count_link_{up,down} to carrier_{up,down}_count to match >> existing carrier_changes semantics > > Like David Ahern I am strongly against the proliferation of sysfs files > attached to network devices and the per-netdevice costs associated with > that. > > However, dealing with that is a longer term issue that nobody has a clear > plan for. Therefore I cannot reject this change on that basis alone. > > The information is useful, so applied, thanks. Thanks! David A, do you have any plans to revive your LWD/LWT devices patches, AFAIR you were allowing a knob disabling the creation of sysfs attributes. -- Florian