mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Li <Frank.Li@nxp.com>, festevam@gmail.com
Cc: clin@suse.com, conor+dt@kernel.org, devicetree@vger.kernel.org,
	eagle.zhou@nxp.com, imx@lists.linux.dev, joy.zou@nxp.com,
	kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
	leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-imx@nxp.com, linux-kernel@vger.kernel.org,
	pierre.gondois@arm.com, robh+dt@kernel.org,
	s.hauer@pengutronix.de, shawnguo@kernel.org,
	shenwei.wang@nxp.com, sherry.sun@nxp.com
Subject: Re: [PATCH v2 1/3] arm64: dts: imx93: add edma1 and edma2
Date: Thu, 24 Aug 2023 18:43:18 +0200	[thread overview]
Message-ID: <c9ede9cd-282a-37b9-4fbb-5b27fb276247@linaro.org> (raw)
In-Reply-To: <20230824163922.2952403-2-Frank.Li@nxp.com>

On 24/08/2023 18:39, Frank Li wrote:
> Add edma<n> nodes.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 116 +++++++++++++++++++++++
>  1 file changed, 116 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index 6f85a05ee7e1..acdca18673b7 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -185,6 +185,46 @@ aips1: bus@44000000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> +			edma1: dma-controller@44000000{

Missing space. In other places as well.

> +				compatible = "fsl,imx93-edma3";
> +				reg = <0x44000000 0x200000>;
> +				#dma-cells = <3>;
> +				dma-channels = <31>;


...

> +				clocks = <&clk IMX93_CLK_EDMA2_GATE>;
> +				clock-names = "dma";
> +				fsl,edma-axi;
> +				status = "okay";

Drop.

> +			};
> +
>  			wakeupmix_gpr: syscon@42420000 {
>  				compatible = "fsl,imx93-wakeupmix-syscfg", "syscon";
>  				reg = <0x42420000 0x1000>;

Best regards,
Krzysztof


  reply	other threads:[~2023-08-24 16:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-24 16:39 [PATCH v2 0/3] arm: dts: imx93: add edmav3 support Frank Li
2023-08-24 16:39 ` [PATCH v2 1/3] arm64: dts: imx93: add edma1 and edma2 Frank Li
2023-08-24 16:43   ` Krzysztof Kozlowski [this message]
2023-08-24 16:39 ` [PATCH v2 1/1] MAINTAINERS: Add entries for NXP(Freescale) eDMA drivers Frank Li
2023-08-24 16:39 ` [PATCH v2 2/3] arm64: dts: imx93: add dma support for lpuart[1..8] Frank Li
2023-08-24 16:39 ` [PATCH v2 2/3] arm64: dts: imx93: add dma support for lpuart[1..9] Frank Li
2023-08-24 16:42   ` Krzysztof Kozlowski
2023-08-24 16:39 ` [PATCH v2 3/3] arm64: dts: imx93-evk: add uart5 Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9ede9cd-282a-37b9-4fbb-5b27fb276247@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Frank.Li@nxp.com \
    --cc=clin@suse.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eagle.zhou@nxp.com \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=joy.zou@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre.gondois@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=shenwei.wang@nxp.com \
    --cc=sherry.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®