From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BB244C121 for ; Fri, 14 Jun 2024 13:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718373561; cv=none; b=VIceiXi9xuopAevE6vi0jTqdGWytH6nEcGbjmRWnaC6rcruRgoAskDqEnv2q3aZ/I8OqtgTYL3SDWszLXDMLQo0nfO1a5wIN7+PC4std7HiZZyJfG2mjPBlzh8KDW14jdH3fTjUXwAz/7ExIS5rKvBSOu0Mkql4bOyWD+/gUb3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718373561; c=relaxed/simple; bh=VzF7H8nx1isKnKUKhtia+u6KmCU39ft5R5J4m1JcvSY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k/C5xLgktML7t3KLkgNJNMVpZrDe5/mR/YE9hsa/O7OWda7KorWdH7JDJvdrNeFEpfqTSomFu0JhD5VZsCSAUiIZr5f7VCZufWIALAKOXnZV2hcYtw2w1f6smH6jLPcDn+RBd9kSE07gjg+4ElxRMZqQ+WwHowPA2WnFLdF41+c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ECF011480; Fri, 14 Jun 2024 06:59:43 -0700 (PDT) Received: from [10.1.196.28] (eglon.cambridge.arm.com [10.1.196.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 776E93F5A1; Fri, 14 Jun 2024 06:59:16 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 14:59:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 29/35] fs/resctrl: Add boiler plate for external resctrl code Content-Language: en-GB To: Dave Martin , x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, "Shaopeng Tan (Fujitsu)" , baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , Peter Newman , dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Rex Nie References: <20240426150537.8094-1-Dave.Martin@arm.com> <20240426150904.8854-1-Dave.Martin@arm.com> <20240426150904.8854-29-Dave.Martin@arm.com> From: James Morse In-Reply-To: <20240426150904.8854-29-Dave.Martin@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Dave, On 26/04/2024 16:08, Dave Martin wrote: > From: James Morse > > Add Makefile and Kconfig for fs/resctrl. Add ARCH_HAS_CPU_RESCTRL > for the common parts of the resctrl interface and make X86_CPU_RESCTRL > depend on this. > FYI: Dave Martin, James Morse (et al.): > > * Review the new Kconfig RESCTRL_FS help text. > > * Because RESCTRL_FS combines a userspace interface and a kernel > library providing services to its own backends, there is a circular > dependency between this option and the arch-specific options > (CONFIG_X86_RESCTRL and eventually CONFIG_ARM64_MPAM) that > nastifies the presentation of these options in Kconfig. > > Can this be improved? > > The current situation works, but is not very user-friendly for > menuconfig users. I don't follow what the circular dependency is - Kconfig would bark if there was one. I agree its odd that you can't disable the filesystem under the filesystem menu - but that is so that the existing Kconfig symbol name remains the switch for this. It's possible no-one cares about that... A more obvious approach would be a switch for the arch hardware feature, that when enabled allows the filesystem to be selected. This seems overkill as there is only one user. Thanks, James