From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D234134A3C5 for ; Thu, 4 Dec 2025 17:35:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764869719; cv=none; b=W7m5QipFMiKFO2inUlom2TYxNlLzIN3LZyKKFIHmFlrjp2XaMas/gjZxN3BcXuXND4rp7LAr9Lo4lc0wmjrK2OU4PVn1RgEAsuisuXQDhwIfWS8qf7lOdWHrTYBpQxDXT8lzMDm9N2a6iJCaPeBPCMIjX/30qFkWFu3dA57mUPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764869719; c=relaxed/simple; bh=RJrF6VOS+3BAz5nEB1+TZdimw8zPQxSfnzdvz6TM/0I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ISrbHWHJGtjTGkbCpG1IhNQ54VIiPXpcZo+IWkRXvTXhlCy4K9UOQiA4eqd0BquvoJceJrwMB+NwM2lsf01c7Mbe4sWY1qqDIsdn0DXQi730kEfMAnLOBcjG3xql072sSlNfu2eQTNPlmnhBG7x0L2CeFlWXbcZre2IANm79c8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=npIIKAy0; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="npIIKAy0" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-6597046fcbdso371633eaf.0 for ; Thu, 04 Dec 2025 09:35:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1764869714; x=1765474514; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SgjVXO0RU8Da0XtOb4CV/bXMWFtkfibexst/jI0YgUY=; b=npIIKAy0kClV5BGJjG1vg1xh6fWguzsbu5eu6RwWsEO+SAfwANUQq9ENyv1b0EekRt QvLoI//I3HGhvmrzgj1s2mDusTdywjlAC2Y5J7tBGu8ONtykoPm8qgAkrnA9jtXAqxq7 QfG235uF1N+vx1bg2VT/nAUE6YGDJZegXbx7i7h7rHdanCc/UBSdSPDK1Hg0Cv6HGHGR niwlGQ24I/QaDTRVEc8n0brKjOGAgCHzKCDnnCCm37h4hhx41jvLRB+W1KiDMftpcFxG fZHk6aWwfJADHlIDltFgi4ZwqugFn96d8thiqkVqOxYAPeu2T6NCZq408dRopu0N34o8 F5Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764869714; x=1765474514; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SgjVXO0RU8Da0XtOb4CV/bXMWFtkfibexst/jI0YgUY=; b=ILYccrLGKEpO8yA4+JAvjeOoB7Yy1pPHDrmGUheiG5ynfPIfGOdTbs1jKwefAcbD5z NNgEOOo3Ai+YM7ByYNlOJobrk8IxGXG9Mj6iy7Sb1NFgZFhmOEivW2SUbA9xmcm0Sbmd gU8mjN6RchhR4/qtfHRPsbWTBoJeSB6v6AENLykK599opVFKtQLTfTXM8z8sYjeNYH8c VVJnq6zrTga2zBntwXXEhhk4B0OmvpecvjNMUlIAr5iJAmtLWfiXrRPAp00yGthK1eLt AcsYmmA0/2I+xK0QOiTngPUc0A39nXNikGaSirPzuMTZvR4Jhr5aQxnmlEqSiooETP+H ueBQ== X-Forwarded-Encrypted: i=1; AJvYcCUUzk0ecUurOjNhpJ7uY7+0EJtaY2ca2X+mvjNPY+fUemQeyb+3OzyEPEU7q5wHYSd5VunPG7Mt45W0suI=@vger.kernel.org X-Gm-Message-State: AOJu0YyCT96hHN9t84IARkXlBkOEJgCvCQbzOqgtgoTPlMoGaJCNayAc hd2gnFqLuALIU8QfpfAK6+yWfiD9E6qcV0ykKKFuU2l+/tMwa+Y8exHYY77z0YRc9m4= X-Gm-Gg: ASbGncvpcJnbg6eWkXZ+RL26jc9jgd3R8z7REmCuiC95psHXCCDoG/OE5J7ptncVw84 JNl6INDK2L1W2a/0IVyFVW8Zgsr9qabaXNTT3AbgAI6l1rFulpDib5JAmFzfSOAjNlSHjPNyaml sfoQYj4RucTJwzsruh3EXysHNNQahnxIN5YdEethTqn5MO+vIsyrxyCScWtVJixvj25KgKuVY/3 dhoH29Qbv9YPa5inIr/2py546V+i3HTlrH/LJyZrlivO8Gq/pdBOX5srLJn1S2M7NMMs/fi7mCv FWgtjg4kN23dSLaZJyJqDTzgBiB4Slp1t3rrCJFP2n1cEAknjq9dciHPcq4AlVNx6Pg1kU3guDd k88ZOhxmLb8PaHQsnIyBv+0/li5mjJc8dETElsNN0CYTuqxbE/mMU/UdWKl8bt18UDHvZryB++N O8FNWksRQbvgwNY7XBk4frJCbtpGhNB9vvXBxA6fLz0dZnpMzdYuQBj9dhoLJj X-Google-Smtp-Source: AGHT+IG44Sj8rkBnNNJIB4NO4CCMMHVuCGhj2JaWu6l839/BoQuyQjUilc5y4oEUHndmxI0MuGTd7Q== X-Received: by 2002:a05:6820:818a:b0:657:56ba:7455 with SMTP id 006d021491bc7-65972623614mr3322771eaf.1.1764869713725; Thu, 04 Dec 2025 09:35:13 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:25f4:78dc:7b9e:e7a4? ([2600:8803:e7e4:500:25f4:78dc:7b9e:e7a4]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6597ec5b35csm1037150eaf.7.2025.12.04.09.35.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 09:35:13 -0800 (PST) Message-ID: Date: Thu, 4 Dec 2025 11:35:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 5/6] iio: health: max30102: Use cleanup.h for IIO locks To: Kurt Borja , Andy Shevchenko , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Benson Leung , Antoniu Miclaus , Gwendal Grignou , Shrikant Raskar , Per-Daniel Olsson Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Guenter Roeck , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev References: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com> <20251203-lock-impr-v1-5-b4a1fd639423@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/4/25 11:07 AM, Kurt Borja wrote: > On Wed Dec 3, 2025 at 4:52 PM -05, David Lechner wrote: >> On 12/3/25 1:18 PM, Kurt Borja wrote: ... >> I would write the whole function like this: >> >> static int max30102_read_raw(struct iio_dev *indio_dev, >> struct iio_chan_spec const *chan, >> int *val, int *val2, long mask) >> { >> struct max30102_data *data = iio_priv(indio_dev); >> int ret; >> >> switch (mask) { >> case IIO_CHAN_INFO_RAW: { >> /* >> * Temperature reading can only be acquired when not in >> * shutdown; leave shutdown briefly when buffer not running >> */ >> guard(iio_device_claim)(indio_dev); > > AFAIK you can't guard() inside switch-case blocks. I don't know the > exact reason, but it has to be scoped_guard(). You can. You just need the braces like I showed in my suggestion. The reason is that guard() is declaring local variables and some compilers like LLVM don't like declaring local variables in a switch case. By adding the { } scope, the variables are limited to that scope and the issue goes away.