From: Andrew Lunn <andrew@lunn.ch>
To: weishangjuan@eswincomputing.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
richardcochran@gmail.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
p.zabel@pengutronix.de, yong.liang.choong@linux.intel.com,
rmk+kernel@armlinux.org.uk, jszhang@kernel.org,
inochiama@gmail.com, jan.petrous@oss.nxp.com,
dfustini@tenstorrent.com, 0x1207@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, ningyu@eswincomputing.com,
linmin@eswincomputing.com, lizhi2@eswincomputing.com
Subject: Re: [PATCH v1 1/2] ethernet: eswin: Document for eic7700 SoC
Date: Mon, 19 May 2025 00:38:13 +0200 [thread overview]
Message-ID: <c9f0cb9e-26e9-43cb-bf67-3fd27033f55c@lunn.ch> (raw)
In-Reply-To: <20250516011040.801-1-weishangjuan@eswincomputing.com>
> + phy-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [mii, gmii, rgmii, rmii, sgmii]
In theory, all four rgmii modes should be listed. In practice, only
rgmii-id is likely to be used.
> +examples:
> + - |
> + gmac0: ethernet@50400000 {
> + compatible = "eswin,eic7700-qos-eth";
> + reg = <0x0 0x50400000 0x0 0x10000>;
> + interrupt-parent = <&plic>;
> + interrupt-names = "macirq";
> + interrupts = <61>;
> + phy-mode = "rgmii";
Please don't use rgmii in an example. It is probably wrong, unless you
have an unusual PCB design.
Andrew
next prev parent reply other threads:[~2025-05-18 22:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 1:08 [PATCH v1 0/2] Add driver support for Eswin eic7700 SoC ethernet controller weishangjuan
2025-05-16 1:10 ` [PATCH v1 1/2] ethernet: eswin: Document for eic7700 SoC weishangjuan
2025-05-16 2:23 ` Rob Herring (Arm)
2025-05-16 13:19 ` Krzysztof Kozlowski
2025-05-18 1:07 ` Inochi Amaoto
2025-05-18 22:38 ` Andrew Lunn [this message]
2025-05-26 5:41 ` Bo Gan
2025-05-16 1:11 ` [PATCH v1 2/2] ethernet: eswin: Add eic7700 ethernet driver weishangjuan
2025-05-16 14:32 ` Jakub Kicinski
2025-05-17 14:11 ` Simon Horman
2025-05-18 1:12 ` Inochi Amaoto
2025-05-18 22:45 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9f0cb9e-26e9-43cb-bf67-3fd27033f55c@lunn.ch \
--to=andrew@lunn.ch \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=edumazet@google.com \
--cc=inochiama@gmail.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linmin@eswincomputing.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lizhi2@eswincomputing.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ningyu@eswincomputing.com \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
--cc=weishangjuan@eswincomputing.com \
--cc=yong.liang.choong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®