From: Johannes Berg <johannes@sipsolutions.net>
To: syzbot <syzbot@kernel.org>,
syzkaller-bugs@googlegroups.com, Slawomir Stepien <sst@poczta.fm>,
linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, syzbot@lists.linux.dev
Subject: Re: [PATCH] wifi: mac80211: reject station association if AP is not started
Date: Thu, 23 Jul 2026 11:14:26 +0200 [thread overview]
Message-ID: <c9fa1c083ef9878240c2ee2fb223413153d93a68.camel@sipsolutions.net> (raw)
In-Reply-To: <373210a9-4365-4cac-823a-0eec391858e7@mail.kernel.org>
On Thu, 2026-07-23 at 08:11 +0000, syzbot wrote:
> From: Slawomir Stepien <sst@poczta.fm>
I'm a bit confused? Did syzbot just pick up another patch?
> dereferences the NULL chanctx_conf, triggering a WARN_ON:
That can't be right?
> Fix this by rejecting the addition or modification of a station to the
> associated state if the AP has not been started (chanctx_conf is NULL).
That's a proxy for "AP is started", but not a good one, I think we
actually have a flag or so somewhere? Maybe even reject it in cfg80211?
> Exempt Multi-Link Operation (MLO) interfaces from this check, as they
> handle chanctx_conf per-link rather than globally on the VIF.
Feels like that's only necessary because the proxy is bad.
Also maybe a similar issue arises if an MLO AP is only half-started, and
stations are added to all links, or so?
johannes
next prev parent reply other threads:[~2026-07-23 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 8:11 syzbot
2026-07-23 9:14 ` Johannes Berg [this message]
2026-07-24 6:50 ` Slawomir Stepien
2026-07-24 7:15 ` Johannes Berg
2026-07-24 12:02 ` Slawomir Stepien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9fa1c083ef9878240c2ee2fb223413153d93a68.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sst@poczta.fm \
--cc=syzbot@kernel.org \
--cc=syzbot@lists.linux.dev \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®