From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753206AbYI3JwJ (ORCPT ); Tue, 30 Sep 2008 05:52:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752015AbYI3Jvy (ORCPT ); Tue, 30 Sep 2008 05:51:54 -0400 Received: from wf-out-1314.google.com ([209.85.200.169]:25059 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbYI3Jvx (ORCPT ); Tue, 30 Sep 2008 05:51:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=K/OL++p/K0Wl3wPQL8MBVKfYIo6gg2q65gt6+OKinpwQD5HE89ITE1OESlSOcvLeEj Z6far6M16jdriKhIqh3gfdT0BBI2VMcQgIzaLRWwHU2dN1gP32Q+KPJV0AZwpgRokwIq ONtcUKzcFDgUMX7TXQugdJsZ4sMYzX9hzP4bg= Message-ID: Date: Tue, 30 Sep 2008 12:51:52 +0300 From: "Matti Linnanvuori" To: "Jeff Garzik" Subject: Re: [patch v1.2.34] WAN: merge driver retina Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <48CC57EB.9010500@pobox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <489A96B2.4030903@pobox.com> <48CC57EB.9010500@pobox.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2008/9/14 Jeff Garzik : > Changes look good, but do not apply to the 'retina' branch. Also, the > virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API > usage. Actually there is one call of virt_to_phys in the patch I sent. I don't know any way to replace virt_to_phys and still use remap_pfn_range. If all architectures support virt_to_phys, I see no reason to replace it with something else. The driver is legacy.