From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751596AbdAMLv2 (ORCPT ); Fri, 13 Jan 2017 06:51:28 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:54053 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751549AbdAMLv0 (ORCPT ); Fri, 13 Jan 2017 06:51:26 -0500 Subject: Re: [PATCH v4 4/5] powerpc/fadump: reuse crashkernel parameter for fadump memory reservation To: Hari Bathini , linux-kernel@vger.kernel.org References: <148363729327.11570.6244765717789390817.stgit@hbathini.in.ibm.com> <148363754236.11570.1527409032997316662.stgit@hbathini.in.ibm.com> Cc: fenghua.yu@intel.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, dyoung@redhat.com, kexec@lists.infradead.org, ebiederm@xmission.com, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, vgoyal@redhat.com From: Mahesh Jagannath Salgaonkar Date: Fri, 13 Jan 2017 17:21:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <148363754236.11570.1527409032997316662.stgit@hbathini.in.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011311-0040-0000-0000-000002E28194 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011311-0041-0000-0000-00000C0F2DDC Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-13_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701130171 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2017 11:02 PM, Hari Bathini wrote: > fadump supports specifying memory to reserve for fadump's crash kernel > with fadump_reserve_mem kernel parameter. This parameter currently > supports passing a fixed memory size, like fadump_reserve_mem= > only. This patch aims to add support for other syntaxes like range-based > memory size :[,:,:,...] > which allows using the same parameter to boot the kernel with different > system RAM sizes. > > As crashkernel parameter already supports the above mentioned syntaxes, > this patch deprecates fadump_reserve_mem parameter and reuses crashkernel > parameter instead, to specify memory for fadump's crash kernel memory > reservation as well. If any offset is provided in crashkernel parameter, > it will be ignored in case of fadump, as fadump reserves memory at end > of RAM. > > Advantages using crashkernel parameter instead of fadump_reserve_mem > parameter are one less kernel parameter overall, code reuse and support > for multiple syntaxes to specify memory. > > Suggested-by: Dave Young > Signed-off-by: Hari Bathini Reviewed-by: Mahesh Salgaonkar > --- > arch/powerpc/kernel/fadump.c | 23 ++++++++++------------- > 1 file changed, 10 insertions(+), 13 deletions(-) > > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c > index db0b339..de7d39a 100644 > --- a/arch/powerpc/kernel/fadump.c > +++ b/arch/powerpc/kernel/fadump.c > @@ -210,14 +210,20 @@ static unsigned long init_fadump_mem_struct(struct fadump_mem_struct *fdm, > */ > static inline unsigned long fadump_calculate_reserve_size(void) > { > - unsigned long size; > + int ret; > + unsigned long long base, size; > > /* > - * Check if the size is specified through fadump_reserve_mem= cmdline > - * option. If yes, then use that. > + * Check if the size is specified through crashkernel= cmdline > + * option. If yes, then use that but ignore base as fadump > + * reserves memory at end of RAM. > */ > - if (fw_dump.reserve_bootvar) > + ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(), > + &size, &base); > + if (ret == 0 && size > 0) { > + fw_dump.reserve_bootvar = (unsigned long)size; > return fw_dump.reserve_bootvar; > + } > > /* divide by 20 to get 5% of value */ > size = memblock_end_of_DRAM() / 20; > @@ -353,15 +359,6 @@ static int __init early_fadump_param(char *p) > } > early_param("fadump", early_fadump_param); > > -/* Look for fadump_reserve_mem= cmdline option */ > -static int __init early_fadump_reserve_mem(char *p) > -{ > - if (p) > - fw_dump.reserve_bootvar = memparse(p, &p); > - return 0; > -} > -early_param("fadump_reserve_mem", early_fadump_reserve_mem); > - > static void register_fw_dump(struct fadump_mem_struct *fdm) > { > int rc; >