From: Juergen Gross <jgross@suse.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: "Vincent Guittot" <vincent.guittot@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
stratos-dev@op-lists.linaro.org,
"Erik Schilling" <erik.schilling@linaro.org>,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Arnd Bergmann" <arnd@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/4] xen: Make struct privcmd_irqfd's layout architecture independent
Date: Mon, 16 Oct 2023 09:13:29 +0200 [thread overview]
Message-ID: <ca0690eb-1f3b-4508-9cf2-079b5ad12e26@suse.com> (raw)
In-Reply-To: <a4ef0d4a68fc858b34a81fd3f9877d9b6898eb77.1697439990.git.viresh.kumar@linaro.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 709 bytes --]
On 16.10.23 09:11, Viresh Kumar wrote:
> Using indirect pointers in an ioctl command argument means that the
> layout is architecture specific, in particular we can't use the same one
> from 32-bit compat tasks. The general recommendation is to have __u64
> members and use u64_to_user_ptr() to access it from the kernel if we are
> unable to avoid the pointers altogether.
>
> Fixes: f8941e6c4c71 ("xen: privcmd: Add support for irqfd")
> Reported-by: Arnd Bergmann <arnd@kernel.org>
> Closes: https://lore.kernel.org/all/268a2031-63b8-4c7d-b1e5-8ab83ca80b4a@app.fastmail.com/
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3149 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2023-10-16 7:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 7:11 [PATCH V4 0/4] xen: privcmd: Add ioeventfd and fix irqfd support Viresh Kumar
2023-10-16 7:11 ` [PATCH V4 1/4] xen: Make struct privcmd_irqfd's layout architecture independent Viresh Kumar
2023-10-16 7:13 ` Juergen Gross [this message]
2023-10-16 7:11 ` [PATCH V4 2/4] xen: irqfd: Use _IOW instead of the internal _IOC() macro Viresh Kumar
2023-10-16 7:14 ` Juergen Gross
2023-10-16 7:11 ` [PATCH V4 3/4] xen: evtchn: Allow shared registration of IRQ handers Viresh Kumar
2023-10-16 7:17 ` Juergen Gross
2023-10-16 7:11 ` [PATCH V4 4/4] xen: privcmd: Add support for ioeventfd Viresh Kumar
2023-10-16 7:25 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca0690eb-1f3b-4508-9cf2-079b5ad12e26@suse.com \
--to=jgross@suse.com \
--cc=alex.bennee@linaro.org \
--cc=arnd@kernel.org \
--cc=erik.schilling@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manos.pitsidianakis@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=stratos-dev@op-lists.linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®