From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 3/5] staging: rtl8192e: Remove one of two checks for hardware RTL8192SE
Date: Wed, 5 Apr 2023 23:48:13 +0200 [thread overview]
Message-ID: <ca07333d0d03878935183025ffab969759aff3cd.1680729715.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1680729715.git.philipp.g.hortmann@gmail.com>
Check for hardware RTL8192SE is done in function _rtl92e_pci_probe()
directly and also two lines later in function rtl92e_check_adapter().
Remove top level check to increase readability.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 7506d7eb7b4c..45989a77a27c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2130,7 +2130,6 @@ static int _rtl92e_pci_probe(struct pci_dev *pdev,
struct r8192_priv *priv = NULL;
unsigned long pmem_start, pmem_len, pmem_flags;
int err = -ENOMEM;
- u8 revision_id;
if (pci_enable_device(pdev)) {
dev_err(&pdev->dev, "Failed to enable PCI device");
@@ -2189,11 +2188,6 @@ static int _rtl92e_pci_probe(struct pci_dev *pdev,
dev->mem_start = ioaddr;
dev->mem_end = ioaddr + pci_resource_len(pdev, 0);
- pci_read_config_byte(pdev, 0x08, &revision_id);
- /* If the revisionid is 0x10, the device uses rtl8192se. */
- if (pdev->device == 0x8192 && revision_id == 0x10)
- goto err_unmap;
-
if (!rtl92e_check_adapter(pdev, dev))
goto err_unmap;
--
2.40.0
next prev parent reply other threads:[~2023-04-05 21:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 21:47 [PATCH 0/5] staging: rtl8192e: Remove unused code for hardware rtl8192se Philipp Hortmann
2023-04-05 21:48 ` [PATCH 1/5] staging: rtl8192e: Remove macro IS_HARDWARE_TYPE_8192SE Philipp Hortmann
2023-04-05 21:48 ` [PATCH 2/5] staging: rtl8192e: Remove unused function _rtl92e_dm_init_wa_broadcom_iot Philipp Hortmann
2023-04-05 21:48 ` Philipp Hortmann [this message]
2023-04-05 21:48 ` [PATCH 4/5] staging: rtl8192e: Remove unused local variable irq_line Philipp Hortmann
2023-04-06 19:54 ` Alison Schofield
2023-04-06 20:06 ` Greg Kroah-Hartman
2023-04-07 8:08 ` Philipp Hortmann
2023-04-07 8:20 ` Greg Kroah-Hartman
2023-04-05 21:48 ` [PATCH 5/5] staging: rtl8192e: Remove unused variable RF_Type Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca07333d0d03878935183025ffab969759aff3cd.1680729715.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®