mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Milan Broz <gmazyland@gmail.com>
To: Linlin Zhang <linlin.zhang@oss.qualcomm.com>,
	Mikulas Patocka <mpatocka@redhat.com>,
	Eric Biggers <ebiggers@kernel.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	adrianvovk@gmail.com, dm-devel@lists.linux.dev,
	quic_mdalam@quicinc.com, israelr@nvidia.com
Subject: Re: [PATCH v1 2/3] dm-inlinecrypt: add target for inline block device encryption
Date: Wed, 25 Mar 2026 16:07:53 +0100	[thread overview]
Message-ID: <ca0c8b55-a600-4067-9477-79f4664a916a@gmail.com> (raw)
In-Reply-To: <c86ff571-092e-4181-9bd9-3e99f7c4b1b2@oss.qualcomm.com>


On 3/25/26 12:57 PM, Linlin Zhang wrote:
> I understood that supporting keyring here is to ensure no raw key exposed to
> dm table. As implied by the name dm-inlinecrypt, the key used by dm-inlinecyrpt
> is a wrapped key, rather raw key. Can we keep the wrapped key inside the mapping
> table?

Whatever key it is, it allows activation of the encrypted device. And it does not
need to be cached inside device-mapper layer (in DM table).

> In other word, can dm-inlinecrypt support both keyring and hex key(key in mapping
> table)?

Yes, support both. There are situations user must use hexkey directly.
But IMO, keyring option should be supported from the beginning.

Thanks,
Milan


  reply	other threads:[~2026-03-25 15:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 12:17 [PATCH v1 0/3] " Linlin Zhang
2026-03-04 12:17 ` [PATCH v1 1/3] block: export blk-crypto symbols required by dm-inlinecrypt Linlin Zhang
2026-03-09 14:01   ` Mikulas Patocka
2026-03-09 15:05   ` Jens Axboe
2026-03-09 16:12     ` Mikulas Patocka
2026-03-04 12:17 ` [PATCH v1 2/3] dm-inlinecrypt: add target for inline block device encryption Linlin Zhang
2026-03-04 13:11   ` Milan Broz
2026-03-25 11:27     ` Linlin Zhang
2026-03-12  7:01   ` Eric Biggers
2026-03-13 13:25     ` Mikulas Patocka
2026-03-13 15:27       ` Milan Broz
2026-03-25 11:57         ` Linlin Zhang
2026-03-25 15:07           ` Milan Broz [this message]
2026-03-25  6:55     ` Linlin Zhang
2026-03-04 12:17 ` [PATCH v1 3/3] dm-inlinecrypt: Expose inline crypto caps to the device Linlin Zhang
2026-03-12  6:35   ` Eric Biggers
2026-03-13 13:19     ` Mikulas Patocka
2026-03-25  6:38     ` Linlin Zhang
2026-03-04 13:06 ` [PATCH v1 0/3] dm-inlinecrypt: add target for inline block device encryption Christoph Hellwig
2026-03-04 18:09   ` Adrian Vovk
     [not found]   ` <CAAdYy_mSB4U39Onwa=V2e2XB0sJXV6tCGkzwV2-z7ZtMcm+8zg@mail.gmail.com>
2026-03-05 14:38     ` Christoph Hellwig
2026-03-25  7:04       ` Linlin Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca0c8b55-a600-4067-9477-79f4664a916a@gmail.com \
    --to=gmazyland@gmail.com \
    --cc=adrianvovk@gmail.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=ebiggers@kernel.org \
    --cc=israelr@nvidia.com \
    --cc=linlin.zhang@oss.qualcomm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=quic_mdalam@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®