From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F155C001DF for ; Fri, 28 Jul 2023 18:41:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229510AbjG1SlE (ORCPT ); Fri, 28 Jul 2023 14:41:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230414AbjG1SlA (ORCPT ); Fri, 28 Jul 2023 14:41:00 -0400 Received: from kozue.soulik.info (kozue.soulik.info [IPv6:2001:19f0:7000:8404:5400:ff:fe00:d7d6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D99649EB; Fri, 28 Jul 2023 11:40:32 -0700 (PDT) Received: from [192.168.10.7] (unknown [10.0.12.132]) by kozue.soulik.info (Postfix) with ESMTPSA id 0D21A300F2B; Sat, 29 Jul 2023 03:39:54 +0900 (JST) DKIM-Filter: OpenDKIM Filter v2.11.0 kozue.soulik.info 0D21A300F2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soulik.info; s=mail; t=1690569600; bh=QEElF6mACLvmrZMLZzPmyID0hHQhIMgI9+CjeYDQ86c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rp8mROI7RfAp4AoFfb06h8q3qJg0KW9F5F6Q6OVMyFs/7JhUNUJ85Ju5FE1um+XnD N2KzBMvZZ2SxbQ4AstUvjTK5IhOAnKKoMef6RuSCGdFSOGZBoahOn84Xtr+e8KYG6x a3jor715vX/5nE8Pyr40Zo1TNCFGY7jIBPOMF1VA= Message-ID: Date: Sat, 29 Jul 2023 02:40:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 2/9] media: vivid: Convert to v4l2_ext_pix_format Content-Language: en-US To: Tomasz Figa Cc: linux-media@vger.kernel.org, Nicolas Dufresne , randy.li@synaptics.com, Brian.Starkey@arm.com, boris.brezillon@collabora.com, frkoenig@chromium.org, hans.verkuil@cisco.com, hiroh@chromium.org, hverkuil@xs4all.nl, kernel@collabora.com, laurent.pinchart@ideasonboard.com, linux-kernel@vger.kernel.org, mchehab@kernel.org, narmstrong@baylibre.com, sakari.ailus@iki.fi, stanimir.varbanov@linaro.org, Helen Koike References: <20230206043308.28365-1-ayaka@soulik.info> <20230206043308.28365-3-ayaka@soulik.info> <20230713103912.favcnhqwjkzvsa6b@chromium.org> <46d15120-6e19-e224-47f3-e0dcbf0aeda5@soulik.info> From: Randy Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/28 15:22, Tomasz Figa wrote: > On Fri, Jul 21, 2023 at 5:10 AM Nicolas Dufresne wrote: >> Le mardi 18 juillet 2023 à 00:00 +0800, Randy Li a écrit : >>> On 2023/7/13 18:39, Tomasz Figa wrote: >>>> On Mon, Feb 06, 2023 at 12:33:01PM +0800, ayaka wrote: >>>>> From: Helen Koike >>>>> >>>>> Simplify Multi/Single planer API handling by converting to v4l2_ext_pix_format. >>>>> >>>>> Duplicate v4l2_ioctl_ops for touch devices. This is done to force the >>>>> framework to use the ext hooks when the classic Api is used from >>>>> userspace in Vid devices, and to keep touch devices with classic hook. >>>>> >>>>> Signed-off-by: Boris Brezillon >>>>> Signed-off-by: Helen Koike >>>>> --- >>>>> Changes in v7: >>>>> - Force the userspace using the new APIs to operate non-touch drivers. >>>> The primary objective of Linux development is not to break the >>>> userspace. We can't just remove the old API, especially not from >>>> existing drivers. >>> Maybe I should create a new virtual driver here? It is impossible to >>> support the new fourcc modifier with the old APIs. >> For MPLANE, where backward compatibility was built into libv4l2 LD_PRELOAD >> wrapper, > Could you refresh my memory on what kind of backwards compatibility we > had in libv4l2? Was that to make it possible to use new MPLANE-only > drivers with old applications? lib/libv4l-mplane/libv4l-mplane.c I think application don't need to know the new MPLANE variant of pixel formats or queue type. >> it simply failed the cases that could not be supported (non contiguous >> planes). >> >> regards, >> Nicolas >> >>>> [snip] >>>>> int vivid_try_fmt_vid_cap(struct file *file, void *priv, >>>>> - struct v4l2_format *f) >>>>> + struct v4l2_ext_pix_format *f) >>>>> { >>>>> - struct v4l2_pix_format_mplane *mp = &f->fmt.pix_mp; >>>>> - struct v4l2_plane_pix_format *pfmt = mp->plane_fmt; >>>>> struct vivid_dev *dev = video_drvdata(file); >>>>> + struct v4l2_plane_pix_format *pfmt = f->plane_fmt; >>>>> const struct vivid_fmt *fmt; >>>>> unsigned bytesperline, max_bpl; >>>>> unsigned factor = 1; >>>>> unsigned w, h; >>>>> unsigned p; >>>>> - bool user_set_csc = !!(mp->flags & V4L2_PIX_FMT_FLAG_SET_CSC); >>>> Why is this condition being removed? >>> Because the v4l2_ext_pix has a struct for the colorspace? >>> >>> Would you like the idea that driver exports a buffer contains all the >>> info for an enumeration ? >>> >>>> Best regards, >>>> Tomasz >>>> >>>>> - fmt = vivid_get_format(dev, mp->pixelformat); >>>>> + fmt = vivid_get_format(dev, f->pixelformat); >>>>> if (!fmt) { >>>>> dprintk(dev, 1, "Fourcc format (0x%08x) unknown.\n", >>>>> - mp->pixelformat); >>>>> - mp->pixelformat = V4L2_PIX_FMT_YUYV; >>>>> - fmt = vivid_get_format(dev, mp->pixelformat); >>>>> + f->pixelformat); >>>>> + f->pixelformat = V4L2_PIX_FMT_YUYV; >>>>> + fmt = vivid_get_format(dev, f->pixelformat); >>>>> } >>>>> >>>>> - mp->field = vivid_field_cap(dev, mp->field); >>>>> + f->field = vivid_field_cap(dev, f->field); >>>>> if (vivid_is_webcam(dev)) { >>>>> const struct v4l2_frmsize_discrete *sz = >>>>> v4l2_find_nearest_size(webcam_sizes, >>>>> VIVID_WEBCAM_SIZES, width, >>>>> - height, mp->width, mp->height); >>>>> + height, f->width, f->height); >>>>> >>>>> w = sz->width; >>>>> h = sz->height; >>>>> @@ -604,14 +603,14 @@ int vivid_try_fmt_vid_cap(struct file *file, void *priv, >>>>> w = dev->src_rect.width; >>>>> h = dev->src_rect.height; >>>>> } >>>>> - if (V4L2_FIELD_HAS_T_OR_B(mp->field)) >>>>> + if (V4L2_FIELD_HAS_T_OR_B(f->field)) >>>>> factor = 2; >>>>> if (vivid_is_webcam(dev) || >>>>> (!dev->has_scaler_cap && !dev->has_crop_cap && !dev->has_compose_cap)) { >>>>> - mp->width = w; >>>>> - mp->height = h / factor; >>>>> + f->width = w; >>>>> + f->height = h / factor; >>>>> } else { >>>>> - struct v4l2_rect r = { 0, 0, mp->width, mp->height * factor }; >>>>> + struct v4l2_rect r = { 0, 0, f->width, f->height * factor }; >>>>> >>>>> v4l2_rect_set_min_size(&r, &vivid_min_rect); >>>>> v4l2_rect_set_max_size(&r, &vivid_max_rect); >>>>> @@ -624,16 +623,15 @@ int vivid_try_fmt_vid_cap(struct file *file, void *priv, >>>>> } else if (!dev->has_scaler_cap && !dev->has_crop_cap) { >>>>> v4l2_rect_set_min_size(&r, &dev->src_rect); >>>>> } >>>>> - mp->width = r.width; >>>>> - mp->height = r.height / factor; >>>>> + f->width = r.width; >>>>> + f->height = r.height / factor; >>>>> } >>>>> >>>>> /* This driver supports custom bytesperline values */ >>>>> >>>>> - mp->num_planes = fmt->buffers; >>>>> for (p = 0; p < fmt->buffers; p++) { >>>>> /* Calculate the minimum supported bytesperline value */ >>>>> - bytesperline = (mp->width * fmt->bit_depth[p]) >> 3; >>>>> + bytesperline = (f->width * fmt->bit_depth[p]) >> 3; >>>>> /* Calculate the maximum supported bytesperline value */ >>>>> max_bpl = (MAX_ZOOM * MAX_WIDTH * fmt->bit_depth[p]) >> 3; >>>>> >>>>> @@ -642,48 +640,49 @@ int vivid_try_fmt_vid_cap(struct file *file, void *priv, >>>>> if (pfmt[p].bytesperline < bytesperline) >>>>> pfmt[p].bytesperline = bytesperline; >>>>> >>>>> - pfmt[p].sizeimage = (pfmt[p].bytesperline * mp->height) / >>>>> + pfmt[p].sizeimage = (pfmt[p].bytesperline * f->height) / >>>>> fmt->vdownsampling[p] + fmt->data_offset[p]; >>>>> - >>>>> - memset(pfmt[p].reserved, 0, sizeof(pfmt[p].reserved)); >>>>> } >>>>> + >>>>> + if (p < VIDEO_MAX_PLANES) >>>>> + pfmt[p].sizeimage = 0; >>>>> + >>>>> for (p = fmt->buffers; p < fmt->planes; p++) >>>>> - pfmt[0].sizeimage += (pfmt[0].bytesperline * mp->height * >>>>> + pfmt[0].sizeimage += (pfmt[0].bytesperline * f->height * >>>>> (fmt->bit_depth[p] / fmt->vdownsampling[p])) / >>>>> (fmt->bit_depth[0] / fmt->vdownsampling[0]); >>>>> >>>>> - if (!user_set_csc || !v4l2_is_colorspace_valid(mp->colorspace)) >>>>> - mp->colorspace = vivid_colorspace_cap(dev); >>>>> + if (!v4l2_is_colorspace_valid(f->colorspace)) >>>>> + f->colorspace = vivid_colorspace_cap(dev); >>>>> >>>>> - if (!user_set_csc || !v4l2_is_xfer_func_valid(mp->xfer_func)) >>>>> - mp->xfer_func = vivid_xfer_func_cap(dev); >>>>> + if (!v4l2_is_xfer_func_valid(f->xfer_func)) >>>>> + f->xfer_func = vivid_xfer_func_cap(dev); >>>>> >>>>> if (fmt->color_enc == TGP_COLOR_ENC_HSV) { >>>>> - if (!user_set_csc || !v4l2_is_hsv_enc_valid(mp->hsv_enc)) >>>>> - mp->hsv_enc = vivid_hsv_enc_cap(dev); >>>>> + if (!v4l2_is_hsv_enc_valid(f->hsv_enc)) >>>>> + f->hsv_enc = vivid_hsv_enc_cap(dev); >>>>> } else if (fmt->color_enc == TGP_COLOR_ENC_YCBCR) { >>>>> - if (!user_set_csc || !v4l2_is_ycbcr_enc_valid(mp->ycbcr_enc)) >>>>> - mp->ycbcr_enc = vivid_ycbcr_enc_cap(dev); >>>>> + if (!v4l2_is_ycbcr_enc_valid(f->ycbcr_enc)) >>>>> + f->ycbcr_enc = vivid_ycbcr_enc_cap(dev); >>>>> } else { >>>>> - mp->ycbcr_enc = vivid_ycbcr_enc_cap(dev); >>>>> + f->ycbcr_enc = vivid_ycbcr_enc_cap(dev); >>>>> } >>>>> >>>>> if (fmt->color_enc == TGP_COLOR_ENC_YCBCR || >>>>> fmt->color_enc == TGP_COLOR_ENC_RGB) { >>>>> - if (!user_set_csc || !v4l2_is_quant_valid(mp->quantization)) >>>>> - mp->quantization = vivid_quantization_cap(dev); >>>>> + if (!v4l2_is_quant_valid(f->quantization)) >>>>> + f->quantization = vivid_quantization_cap(dev); >>>>> } else { >>>>> - mp->quantization = vivid_quantization_cap(dev); >>>>> + f->quantization = vivid_quantization_cap(dev); >>>>> } >>>>> >>>>> - memset(mp->reserved, 0, sizeof(mp->reserved)); >>>>> + memset(f->reserved, 0, sizeof(f->reserved)); >>>>> return 0; >>>>> } >>>> [snip]