From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751885AbdGUEqG (ORCPT ); Fri, 21 Jul 2017 00:46:06 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:60802 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750771AbdGUEqE (ORCPT ); Fri, 21 Jul 2017 00:46:04 -0400 Subject: Re: [PATCH] net: ethernet: ti: cpsw: Push the request_irq function to the end of probe To: Grygorii Strashko , David Miller References: <1500550192-6550-1-git-send-email-j-keerthy@ti.com> <5259f0e7-cc5d-35c9-8f09-94cf7b40f653@ti.com> <20170720.152831.802536956243282259.davem@davemloft.net> <0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com> CC: , , , , , , From: Keerthy Message-ID: Date: Fri, 21 Jul 2017 10:15:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <0a5cdde6-5898-8f8c-5c56-d47fa9513958@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 21 July 2017 04:14 AM, Grygorii Strashko wrote: > > > On 07/20/2017 05:28 PM, David Miller wrote: >> From: Grygorii Strashko >> Date: Thu, 20 Jul 2017 11:08:09 -0500 >> >>> In general patch looks good to me, but it's really unexpected to >>> receive IRQs while CPSW is probing ;( >> >> This is a poor expectation. >> >> Boot loaders and other entities can leave the device in any state >> whatsoever. >> >> Furthermore, enabling an IRQ whose handler cannot properly execute >> without crashing is wrong fundamentally. All data structures and >> state must be set up properly before the IRQ is requested. >> >> Therefore this patch is correct and I will apply it. >> > > Thanks. Agree (it just has never triggered before, so I meant - unexpected > from current driver code point of view ;(). > And I'm just worry that it might not be enough :(, especially for am335x. I tried nfs boot on am335x-evm with this patch and it boots fine for me. >