From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752315AbeBHVem (ORCPT ); Thu, 8 Feb 2018 16:34:42 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41663 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbeBHVel (ORCPT ); Thu, 8 Feb 2018 16:34:41 -0500 Subject: Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error To: Marek Vasut , Heiko Schocher , linux-can@vger.kernel.org Cc: Markus Marb , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wolfgang Grandegger References: <20180208064748.17985-1-hs@denx.de> <59322f7d-4207-a5a4-89b5-dff1634e4183@pengutronix.de> From: Marc Kleine-Budde Message-ID: Date: Thu, 8 Feb 2018 22:33:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AjzWQDiH4BTjT9M1jcvMMIAvLcuVe9UvA" X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AjzWQDiH4BTjT9M1jcvMMIAvLcuVe9UvA Content-Type: multipart/mixed; boundary="O3JBU05ZpuhadwbMSXPFnpyaJSgR8MAI1"; protected-headers="v1" From: Marc Kleine-Budde To: Marek Vasut , Heiko Schocher , linux-can@vger.kernel.org Cc: Markus Marb , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wolfgang Grandegger Message-ID: Subject: Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error References: <20180208064748.17985-1-hs@denx.de> <59322f7d-4207-a5a4-89b5-dff1634e4183@pengutronix.de> In-Reply-To: --O3JBU05ZpuhadwbMSXPFnpyaJSgR8MAI1 Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable On 02/08/2018 08:22 PM, Marek Vasut wrote: > On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >> On 02/08/2018 07:47 AM, Heiko Schocher wrote: >>> the driver reads in the ISR first the IRQpending register, >>> and clears after that in a write *all* bits in it. >>> >>> It could happen that the isr register raise bits between >>> this 2 register accesses, which leads in lost bits ... >>> >>> In case it clears "TX message sent successfully", the driver >>> never sends any Tx data, and buffers to userspace run over. >>> >>> Fixed this: >>> clear only the bits in the IRQpending register, the >>> driver had read. >>> >>> Signed-off-by: Heiko Schocher >>> Reviewed-by: Marek Vasut >> >> Applied both to linux-can. >=20 > Can you also apply them to stable, so they get into 4.9.x etc ? I've already added stable on Cc, so they will be picked up by the stable maintainers. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | --O3JBU05ZpuhadwbMSXPFnpyaJSgR8MAI1-- --AjzWQDiH4BTjT9M1jcvMMIAvLcuVe9UvA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEENrCndlB/VnAEWuH5k9IU1zQoZfEFAlp8wkMACgkQk9IU1zQo ZfE7FggAr/8DWqoGIVzkjlBsFruOMFUvtM/nKU3cFX6DwndYf7m9Z1LTk2WdpC3J EgdfbDLms/CtGEoTCApVMxVcvAQwoQyyrd8QJYefJrBBQKenYATi8xX4pkpU0P9S cNL7jVYPpDnFECM/OZR222tU6yy90W5Aw7ZG29S5jcf4skqVC189khTTgwlhks0B j+TLHDUKEJbk/pGzz/pWG/dvK7r7dnlpdB5EyR/0zhMdi54WPtQ0QRnaFU/ImYL5 e8EUX/sQYSGcQfPEUZIKQSAv6Dht6h3CNfzipc1JvvTFs+W7FWTDfc5hg+nNTlbP fFU+r2FZ2pRJ3LTPDHYd68DXCRMdUQ== =G2Z6 -----END PGP SIGNATURE----- --AjzWQDiH4BTjT9M1jcvMMIAvLcuVe9UvA--