From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Wolfgang Grandegger <wg@grandegger.com>,
Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Felipe Balbi (Intel)" <balbi@kernel.org>,
Matt Kline <matt@bitbashing.io>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] can: m_can: pci: fix iomap_read_fifo() and iomap_write_fifo()
Date: Thu, 18 Nov 2021 17:09:35 +0200 [thread overview]
Message-ID: <ca1c6275-1609-466e-95b5-d7ad5083f666@linux.intel.com> (raw)
In-Reply-To: <20211118144011.10921-1-matthias.schiffer@ew.tq-group.com>
On 11/18/21 4:40 PM, Matthias Schiffer wrote:
> The same fix that was previously done in m_can_platform in commit
> 99d173fbe894 ("can: m_can: fix iomap_read_fifo() and iomap_write_fifo()")
> is required in m_can_pci as well to make iomap_read_fifo() and
> iomap_write_fifo() work for val_count > 1.
>
> Fixes: 812270e5445b ("can: m_can: Batch FIFO writes during CAN transmit")
> Fixes: 1aa6772f64b4 ("can: m_can: Batch FIFO reads during CAN receive")
> Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> ---
> drivers/net/can/m_can/m_can_pci.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
I tested this on top of plain v5.15 (v5.16-rc1 has some rootfs
regression on my EHL HW) where my test case was receiving zeros and this
makes it working again like in v5.14 and earlier.
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2021-11-18 15:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 14:40 Matthias Schiffer
2021-11-18 15:09 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1c6275-1609-466e-95b5-d7ad5083f666@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=balbi@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@bitbashing.io \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®