From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mxout70.expurgate.net (mxout70.expurgate.net [194.37.255.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE6943491C2 for ; Tue, 17 Mar 2026 06:53:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.37.255.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773730402; cv=none; b=aK6MS4vqVflAAV6/Ukj6keiSr3JEaB7IwPvAiLIrBsgsxR4sqdWcuwEsDhaCIm1Hf/d90swpabHb3mq+KRYCL9kz+9QQN/GrPSPkcuEPdAWbKjw3bJMwlbb9iqM97j73vpVBjyGFTMQoAIeZyvafQCshifP3foPCB34Hpznxn9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773730402; c=relaxed/simple; bh=tGoKoocLWMEpIHHp0Hn7XhBgRZl4XoI/VXMo8hYyFUg=; h=MIME-Version:Content-Type:Date:From:To:Cc:Subject:In-Reply-To: References:Message-ID; b=Oxxy1CG21MvG/msSrE/W1vu59ejt5MXVuPG++JVvksn+3V7YODk+QsGW8XWtH59guTUl40lMGAjCzjZUPwTOB4EDtQ0/ABDvwmbA4Dlotjn+JJ8fiC2tGDNfHwudcrT4vGurRbVGzf7BEAXJqTKMIp4lQe7afa+Gqg9QJAULn2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de; spf=pass smtp.mailfrom=dev.tdt.de; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b=GosmovSW; arc=none smtp.client-ip=194.37.255.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dev.tdt.de Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=dev.tdt.de header.i=@dev.tdt.de header.b="GosmovSW" Received: from [194.37.255.9] (helo=mxout.expurgate.net) by relay.expurgate.net with smtp (Exim 4.92) (envelope-from ) id 1w2OIZ-00EIAh-4P; Tue, 17 Mar 2026 07:53:03 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w2OIX-00EI79-K7; Tue, 17 Mar 2026 07:53:01 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dev.tdt.de; s=z1-selector1; t=1773730381; bh=tGoKoocLWMEpIHHp0Hn7XhBgRZl4XoI/VXMo8hYyFUg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GosmovSWUd8k8899cf6i/S1ISxLLsNsu6vjYbCHnXwOE47cDrwsRP+9T8TY026u8q 5wymbg63WRBoqYZKeQqK7vcANYgJEHQ+k/lCcBvp+BoKEvC68qqdrtxosuw9ycTkh9 JJrEk2+gr3tMuI5lFSCAMnrLKPnUWLUcEDgqmFl2OeFMEhcp35rpXn0piM5B/C4qlN Y/pLqn1a2KjdLUF3XicVGsqcZGnY4OWjZ2mnpQXHeGrW6oRXRdT1UFY/XXNW6jDfIW 0QMSRdQeaMPG90g8EEzT4Xk/r0VizIQZ1cECKfnKM3zGhbY07XwJXcReK3ilKxE7Sz 202WnYvV9Vqrg== Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 2A769240040; Tue, 17 Mar 2026 07:53:01 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 20B37240036; Tue, 17 Mar 2026 07:53:01 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 6E63C2379F; Tue, 17 Mar 2026 07:53:00 +0100 (CET) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Tue, 17 Mar 2026 07:53:00 +0100 From: Martin Schiller To: srinivas pandruvada Cc: "Rafael J. Wysocki" , Len Brown , Viresh Kumar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Florian Eckert Subject: Re: [PATCH 0/2] x86/cpu: P-state support for Lightning Mountain Organization: TDT AG In-Reply-To: <42e71412208dcb6fc75bf5b606bd2ec0f0eaa21e.camel@linux.intel.com> References: <20260306-cpufreq_lgm-v1-0-47f104aed7c2@dev.tdt.de> <3e828b47bacf84ca8d19a024ac71778c@dev.tdt.de> <42e71412208dcb6fc75bf5b606bd2ec0f0eaa21e.camel@linux.intel.com> Message-ID: X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.17 Content-Transfer-Encoding: quoted-printable X-purgate: clean X-purgate-type: clean X-purgate-ID: 151534::1773730382-D66515F5-E8164315/0/0 On 2026-03-09 16:57, srinivas pandruvada wrote: > On Mon, 2026-03-09 at 07:53 +0100, Martin Schiller wrote: >> On 2026-03-06 18:59, Rafael J. Wysocki wrote: >> > On Fri, Mar 6, 2026 at 9:27=E2=80=AFAM Martin Schiller >> > wrote: >> > > >> > > This patch set contains 2 commits to get P-state support for >> > > Intel / >> > > MaxLinear Lightning Mountain. The first adds the needed code to >> > > the >> > > intel_pstate driver. The second adds a workaround to the x86/cpu >> > > subsystem to enable EIST on all cpus. >> > >> > Can you please combine the patches? >> > >> > Or does the first one work just fine without the second one? >>=20 >> Well, the first patch can basically be applied without the second >> one, >> but then frequency stepping will only work on the first cpu core. >>=20 >> I split the two changes because they apply to different parts of the >> kernel sources. >>=20 >> But you're probably right, and it makes sense to combine the two >> patches. >>=20 >>=20 >> BTW: The original code from the MaxLinear SDK enables EIST in the >> intel_pstate driver, but I don't think that's the right place for it. >=20 > This is a special case. But intel_pstate driver can be disabled from > kernel command line to use acpi cpufreq driver. So in that case > enabling in intel_pstate will not help. You're basically right, but the MaxLinear Lightning Mountain doesn't support ACPI either, so the acpi cpufreq driver wouldn't work anyway. So perhaps it would be best after all if I integrated this routine into the intel_pstate driver. Regards, Martin