mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vasant Hegde <vasant.hegde@amd.com>
To: Joerg Roedel <joro@8bytes.org>, iommu@lists.linux.dev
Cc: Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
	Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()
Date: Tue, 29 Oct 2024 22:01:42 +0530	[thread overview]
Message-ID: <ca1c84e2-f36f-4384-a3b4-4eb095bdaddc@amd.com> (raw)
In-Reply-To: <20241029105849.52069-1-joro@8bytes.org>

On 10/29/2024 4:28 PM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
> 
> The iommu_paging_domain_alloc_flags() prototype for
> non-iommu kernel configurations lacks the 'static inline'
> prefixes.
> 
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Vasant Hegde <vasant.hegde@amd.com>
> Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>

Sorry. I missed to fix this one.

Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant


> ---
>  include/linux/iommu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index aa78d911fdda..522efdc7d815 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -1080,7 +1080,7 @@ static inline bool device_iommu_capable(struct device *dev, enum iommu_cap cap)
>  	return false;
>  }
>  
> -struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
> +static inline struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
>  						     unsigned int flags)
>  {
>  	return ERR_PTR(-ENODEV);


      parent reply	other threads:[~2024-10-29 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 10:58 Joerg Roedel
2024-10-29 11:43 ` Jason Gunthorpe
2024-10-29 16:31 ` Vasant Hegde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca1c84e2-f36f-4384-a3b4-4eb095bdaddc@amd.com \
    --to=vasant.hegde@amd.com \
    --cc=iommu@lists.linux.dev \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®