mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: linux-fsi@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, broonie@kernel.org,
	gregkh@linuxfoundation.org, rafael@kernel.org, jk@ozlabs.org,
	joel@jms.id.au, alistair@popple.id.au
Subject: Re: [PATCH v2 0/5] fsi: Add regmap and refactor sbefifo
Date: Thu, 19 Jan 2023 11:48:48 -0600	[thread overview]
Message-ID: <ca233daf-1bcd-3b2e-68bc-2b9d48f4c7ee@linux.ibm.com> (raw)
In-Reply-To: <20221102205148.1334459-1-eajames@linux.ibm.com>


On 11/2/22 15:51, Eddie James wrote:
> The SBEFIFO hardware can now be attached over a new I2C endpoint interface
> called the I2C Responder (I2CR). In order to use the existing SBEFIFO
> driver, add a regmap driver for the FSI bus and an endpoint driver for the
> I2CR. Then, refactor the SBEFIFO and OCC drivers to clean up and use the
> new regmap driver or the I2CR interface.


I'm abandoning the rest of this series in favor of an FSI master driver 
through the I2C responder. It makes a lot more sense to implement a 
master driver here because then we get all the engine drivers for free, 
rather than rework them to talk over i2c.

Thanks,

Eddie


>
> Changes since v1:
>   - Instead of a regmap driver for the I2CR, just have a private interface
>     driver for FSI, since SBEFIFO is likely the only user.
>
> Eddie James (5):
>    regmap: Add FSI bus support
>    drivers: fsi: Add I2C Responder driver
>    drivers: fsi: Rename sbefifo and occ sources
>    drivers: fsi: separate char device code for occ and sbefifo
>    drivers: fsi: occ and sbefifo refactor
>
>   drivers/base/regmap/Kconfig      |    6 +-
>   drivers/base/regmap/Makefile     |    1 +
>   drivers/base/regmap/regmap-fsi.c |  231 ++++++
>   drivers/fsi/Kconfig              |   32 +-
>   drivers/fsi/Makefile             |    9 +-
>   drivers/fsi/fsi-occ.c            |  766 --------------------
>   drivers/fsi/fsi-sbefifo.c        | 1144 ------------------------------
>   drivers/fsi/i2cr.c               |  116 +++
>   drivers/fsi/i2cr.h               |   19 +
>   drivers/fsi/occ-cdev.c           |  157 ++++
>   drivers/fsi/occ.c                |  536 ++++++++++++++
>   drivers/fsi/occ.h                |   57 ++
>   drivers/fsi/sbefifo-cdev.c       |  218 ++++++
>   drivers/fsi/sbefifo-fsi.c        |   68 ++
>   drivers/fsi/sbefifo-i2c.c        |   73 ++
>   drivers/fsi/sbefifo.c            |  797 +++++++++++++++++++++
>   drivers/fsi/sbefifo.h            |   50 ++
>   include/linux/regmap.h           |   37 +
>   18 files changed, 2398 insertions(+), 1919 deletions(-)
>   create mode 100644 drivers/base/regmap/regmap-fsi.c
>   delete mode 100644 drivers/fsi/fsi-occ.c
>   delete mode 100644 drivers/fsi/fsi-sbefifo.c
>   create mode 100644 drivers/fsi/i2cr.c
>   create mode 100644 drivers/fsi/i2cr.h
>   create mode 100644 drivers/fsi/occ-cdev.c
>   create mode 100644 drivers/fsi/occ.c
>   create mode 100644 drivers/fsi/occ.h
>   create mode 100644 drivers/fsi/sbefifo-cdev.c
>   create mode 100644 drivers/fsi/sbefifo-fsi.c
>   create mode 100644 drivers/fsi/sbefifo-i2c.c
>   create mode 100644 drivers/fsi/sbefifo.c
>   create mode 100644 drivers/fsi/sbefifo.h
>

      parent reply	other threads:[~2023-01-19 17:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02 20:51 Eddie James
2022-11-02 20:51 ` [PATCH v2 1/5] regmap: Add FSI bus support Eddie James
2022-11-03 14:54   ` Mark Brown
2022-11-03 14:59     ` Eddie James
2022-11-02 20:51 ` [PATCH v2 2/5] drivers: fsi: Add I2C Responder driver Eddie James
2022-11-02 20:51 ` [PATCH v2 3/5] drivers: fsi: Rename sbefifo and occ sources Eddie James
2022-11-02 20:51 ` [PATCH v2 4/5] drivers: fsi: separate char device code for occ and sbefifo Eddie James
2022-11-02 20:51 ` [PATCH v2 5/5] drivers: fsi: occ and sbefifo refactor Eddie James
2022-11-25 21:28 ` (subset) [PATCH v2 0/5] fsi: Add regmap and refactor sbefifo Mark Brown
2023-01-19 17:48 ` Eddie James [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca233daf-1bcd-3b2e-68bc-2b9d48f4c7ee@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=alistair@popple.id.au \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome