From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF02A5275A3 for ; Thu, 15 Oct 2026 13:01:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792069282; cv=none; b=BPSNdxo2LxjIEKplXRkH2quQmW63gyv42YE6kPF7idDIiy5M0B+vmRk8oCNujQapLnfqyo1QReIF6CYcKXRmND3QEihpv8Zgc6FJn4DXOGW8S6CeRvJnc9Ps6LKBp7xflIzJhJEkwJ78ybUQZ82HAd/Tu+8gj/6x2v4ONgcunJM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792069282; c=relaxed/simple; bh=M00L0DQuv05+wzHwVamvXqjP2sz1GvUfTGsI+8cDoWI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jzLe4JBxGs4hvWMDL8GvLBQDJDSEeQdX2RU38gke3kbIvFvNgB9AJyMMBlj9lYU0SOCE7U4DKBEXt5MX1S4WtZ55DlCs0Y6XGyk1kXyzTvT4zHBEzC2RgF5z+gHBh2ED7S1/tPqeP5dvlPEH6TIzJHWeZg7FBPb3aFFX+w2noLs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=MDe+XW3s; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="MDe+XW3s" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-4f66bb2ab57so2183060b6e.3 for ; Thu, 15 Oct 2026 06:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1792069279; x=1792674079; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cjFxj3bFbYPisDR6RrznzneRHAUvWft2WkzURGoz+vk=; b=MDe+XW3sZGIKUEnYlfRZINRq8F9iFr7onbzNEHeWmvCuwXJaqwkGKfQ9gFok5rB8Id IaJAjtROcVBzCDsrrDR69dw49e3I5biC8O2qfPa3WkToEm+M3D3LvUFNbnGyedARiCtk cNZtA9RnUSfGGYHtfOcSZRqahDFL6o4H7lgUWZUr2DDzs0IzALO1ecLg7sWiv+lRCKvf 5XjUjwtQq5pw5W7ZOKOapISX4hwDWYsyK8+tAfyvkAEoBSgrY5CncfdpHFa5L0owkHYQ TUTamUfG19ipMTGB++x8MWjdt8HWuPUcUIAQCQobn7hdzkM+MnCt+QPNSuXhetr+IvwI oUpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792069279; x=1792674079; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cjFxj3bFbYPisDR6RrznzneRHAUvWft2WkzURGoz+vk=; b=lZf1OcbxpYFK5oRg9SqqRQKPwj23UqAAsaZY+4pjIuUKte1nfLg/yV5CDexEVrynwa T92mZuzpBgls4tmsD7Dod3Ge7Hxv+GkG+RO9Bq4gtj54qWrX+g2ay7oVaRQH7i/skPMj wQApWaV7Q9XSOpbRTlJVX0hVWRSoOGCTErOeZ8JD+CASOMnm8ztFdFGz/3yOnsx/DHQ6 r5bENERp3+zqoKpQPuKvR+BIE2ww6inl2pxBJm2nfs004Il4l1VNqm+QYcKcwByZ30Ry es/d8IrmZUtQFFB19d75Y6iPj3rJeKY7T5finalogTsnxaLTNSbirsVGA2rWyZQ5bgK0 qQtQ== X-Forwarded-Encrypted: i=1; AKwUvByxmU4bICUPGb6g67UPtQ4tiXYyEpiyJi/iepJ7Jh8QF+I51TQFoO6YdhxkogUQxnwL/q+6my2L0ypjWyM=@vger.kernel.org X-Gm-Message-State: AFq9FYJCfetvDbFXKKLFYmddW5Dq2tBwv1p0ZXBWUq5R80/iXx7pI/kY BJ6nW7hMyGkRC7qLBBL3mBgcEyiXE1vhCx+iEhObwNPHHJV4ikllirUlTD0+WIBcpVM= X-Gm-Gg: AYBFou1mNIpSxmeua/aJbPWbv9PBgslG4u/aSBy6+9yyMyTfjNQXgdne89w8GioceAm pGaMNa7Q7FjLWaFIMNwRiRTgoejlu2EgOH+pWXvxQDHoCVisFDPyrndfsQGp0BKCCFLsjj6Y6kC nLHOxAUTFK+88jLlSqeBeGM83ll/KLUpZakol4EOgPkYz8IxWZxtuTB4k8VgdcHTnnn+p31un3Y MsLkgabFuzkLuUQsF1u3vJvDymt+KUHlpOgEHHbHWE4NXOEd65MSUTProwyJAcHQZXI3itc5o3k tRJoRzwr/lZ4wYSZHzORoUD4i3GMfYmemgB19EfNUyBKqUvrQCbNP2o5tbaSdnBZBv+cNswE9TK gQ3SvZeaAFmSy+fpoFIsKQh98caQ4hWqApgJ5VQI0iNZPLu1D7b8t4LvazoZxLYd/9CpHgzFELG JEe4yYiQS7OSTF3xvGu4VyYeinIODDUYNKcKgr0LBh4OMSPZak92oOd/ZeewK6/oDgp4RZum7YK UGb7fdESAsj3wVl5WPNhqseCxH2o/QpMMn8BQde/NRaE8UW5cJT2Mtf0JY= X-Received: by 2002:a05:6808:1387:b0:4f6:6041:f0a2 with SMTP id 5614622812f47-50c5482ee7amr19056488b6e.27.1792069279336; Thu, 15 Oct 2026 06:01:19 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:7a64:39ea:e5ac:f974? ([2600:8803:e7e4:500:7a64:39ea:e5ac:f974]) by smtp.gmail.com with ESMTPSA id 5614622812f47-50c1674ddf8sm18952180b6e.4.2026.10.15.06.01.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Oct 2026 06:01:16 -0700 (PDT) Message-ID: Date: Thu, 15 Oct 2026 08:01:14 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] iio: adc: ti-ads112c14: add gpio support To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Chris Hall , Patrick Edwards , Kurt Borja , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Linus Walleij References: <20261009-iio-adc-ti-ads112c14-gpio-v2-0-3231a795fa63@baylibre.com> <20261009-iio-adc-ti-ads112c14-gpio-v2-2-3231a795fa63@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/13/26 9:05 AM, Andy Shevchenko wrote: > On Sat, Oct 10, 2026 at 08:46:30AM -0500, David Lechner wrote: >> On 10/10/26 4:00 AM, Bartosz Golaszewski wrote: >>> On Sat, 10 Oct 2026 01:25:52 +0200, "David Lechner (TI)" >>> said: > > ... > >>>> + if (device_property_read_bool(dev, "gpio-controller")) { >>> >>> I think the right one to use is device_property_present(). >> >> I thought this was the one case where device_property_read_bool() is >> actually correct because gpio-controller property is a >> /schemas/types.yaml#/definitions/flag. >> >> Otherwise, we should just remove device_property_read_bool() from the tree >> because there would never be a reason to use it. >> >> My understanding is we should use device_property_present() for non-boolean >> properties when we want to know if it is present or not before reading the >> value of it. > > That's not true. The _property_present() checks any type of property, while > _property_read_bool() returns an actual value of the flag, while they might > overlap in the behaviour, they are semantically completely different. > That is exactly what I said.