From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbeACGFX (ORCPT + 1 other); Wed, 3 Jan 2018 01:05:23 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:41535 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751140AbeACGFV (ORCPT ); Wed, 3 Jan 2018 01:05:21 -0500 Subject: Re: [PATCH v3 06/27] gpio: replace devm_ioremap_nocache with devm_ioremap To: Linus Walleij References: <1514026690-32863-1-git-send-email-xieyisheng1@huawei.com> CC: "linux-kernel@vger.kernel.org" , Greg KH , , From: Yisheng Xie Message-ID: Date: Wed, 3 Jan 2018 14:05:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.40] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 2018/1/2 16:41, Linus Walleij wrote: > On Sat, Dec 23, 2017 at 11:58 AM, Yisheng Xie wrote: > >> Default ioremap is ioremap_nocache, so devm_ioremap has the same >> function with devm_ioremap_nocache, which can just be killed to >> save the size of devres.o >> >> This patch is to use use devm_ioremap instead of devm_ioremap_nocache, >> which should not have any function change but prepare for killing >> devm_ioremap_nocache. >> >> Cc: Linus Walleij >> Cc: linux-gpio@vger.kernel.org >> Signed-off-by: Yisheng Xie Well, I list the ARCHs related to the change file, do not include cris,ia64,mn10300 and openrisc, which ioremap is not the same as ioremap_nocache, as discussed in cover letter. So please let me know if I need update the comment. change_file ARCH drivers/gpio/gpio-ath79.c | 3 +-- mips drivers/gpio/gpio-em.c | 6 ++---- arm drivers/gpio/gpio-htc-egpio.c | 4 ++-- arm drivers/gpio/gpio-xgene.c | 3 +-- arm64 Thanks Yisheng > > Patch applied. > > Yours, > Linus Walleij > >