From: "Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
To: "Akinobu Mita" <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"Miguel Ojeda Sandonis" <maxextreme@gmail.com>
Subject: Re: [PATCH] auxdisplay: small cleanups
Date: Sun, 6 Jul 2008 02:12:27 +0200 [thread overview]
Message-ID: <ca2dc2820807051712w3aaa876bn230269369424af1f@mail.gmail.com> (raw)
In-Reply-To: <20080705112116.GC17071@localhost.localdomain>
On Sat, Jul 5, 2008 at 1:21 PM, Akinobu Mita <akinobu.mita@gmail.com> wrote:
> - Use BUILD_BUG_ON for CFAG12864B_SIZE instead of runtime-check
>
> - Use get_zeroed_page()
Thank you very much! I will test it soon (~10th of July). In the meantime:
Signed-off-by: Miguel Ojeda Sandonis <maxextreme@gmail.com>
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Miguel Ojeda Sandonis <maxextreme@gmail.com>
> ---
> drivers/auxdisplay/cfag12864b.c | 13 ++-----------
> 1 file changed, 2 insertions(+), 11 deletions(-)
>
> Index: 2.6-git/drivers/auxdisplay/cfag12864b.c
> ===================================================================
> --- 2.6-git.orig/drivers/auxdisplay/cfag12864b.c
> +++ 2.6-git/drivers/auxdisplay/cfag12864b.c
> @@ -336,16 +336,9 @@ static int __init cfag12864b_init(void)
> "ks0108 is not initialized\n");
> goto none;
> }
> + BUILD_BUG_ON(PAGE_SIZE < CFAG12864B_SIZE);
>
> - if (PAGE_SIZE < CFAG12864B_SIZE) {
> - printk(KERN_ERR CFAG12864B_NAME ": ERROR: "
> - "page size (%i) < cfag12864b size (%i)\n",
> - (unsigned int)PAGE_SIZE, CFAG12864B_SIZE);
> - ret = -ENOMEM;
> - goto none;
> - }
> -
> - cfag12864b_buffer = (unsigned char *) __get_free_page(GFP_KERNEL);
> + cfag12864b_buffer = (unsigned char *) get_zeroed_page(GFP_KERNEL);
> if (cfag12864b_buffer == NULL) {
> printk(KERN_ERR CFAG12864B_NAME ": ERROR: "
> "can't get a free page\n");
> @@ -367,8 +360,6 @@ static int __init cfag12864b_init(void)
> if (cfag12864b_workqueue == NULL)
> goto cachealloced;
>
> - memset(cfag12864b_buffer, 0, CFAG12864B_SIZE);
> -
> cfag12864b_clear();
> cfag12864b_on();
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
prev parent reply other threads:[~2008-07-06 0:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-05 11:21 Akinobu Mita
2008-07-06 0:12 ` Miguel Ojeda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca2dc2820807051712w3aaa876bn230269369424af1f@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxextreme@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®