From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] move cfag12864bfb's probe function to .devinit.text
Date: Tue, 20 Jan 2009 09:13:25 +0100 [thread overview]
Message-ID: <ca2dc2820901200013y3723785cjb4ca4a0e223f7993@mail.gmail.com> (raw)
In-Reply-To: <1231799107-20136-8-git-send-email-u.kleine-koenig@pengutronix.de>
On Mon, Jan 12, 2009 at 11:24 PM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> A pointer to cfag12864bfb_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded. Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
Thank you for the patch!
>
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
Is that solution better? What are the pros/cons?
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/auxdisplay/cfag12864bfb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/auxdisplay/cfag12864bfb.c b/drivers/auxdisplay/cfag12864bfb.c
> index fe3a865..b0ca5a4 100644
> --- a/drivers/auxdisplay/cfag12864bfb.c
> +++ b/drivers/auxdisplay/cfag12864bfb.c
> @@ -81,7 +81,7 @@ static struct fb_ops cfag12864bfb_ops = {
> .fb_mmap = cfag12864bfb_mmap,
> };
>
> -static int __init cfag12864bfb_probe(struct platform_device *device)
> +static int __devinit cfag12864bfb_probe(struct platform_device *device)
> {
> int ret = -EINVAL;
> struct fb_info *info = framebuffer_alloc(0, &device->dev);
> --
> 1.5.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2009-01-20 8:13 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-12 22:12 platform_driver's probe functions must not be located in .init.text Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move acornfb's probe function to .devinit.text Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move am79c961's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move arcfb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move at91_ether's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move at91_wdt's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move bf54x-lq043's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move bfin-t350mcqb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move cfag12864bfb's " Uwe Kleine-König
2009-01-20 8:13 ` Miguel Ojeda [this message]
2009-01-20 9:29 ` Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move leds-clevo-mail's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move cobalt-lcd's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move corgi-keyboard's " Uwe Kleine-König
2009-01-13 6:20 ` Dmitry Torokhov
2009-01-12 22:24 ` [PATCH] move corgi-ssp's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move corgi-ts's " Uwe Kleine-König
2009-01-13 6:20 ` Dmitry Torokhov
2009-01-12 22:24 ` [PATCH] move efifb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move orion-ehci's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move epson1355fb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sh_flctl's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move gbefb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move h1940-bt's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move h1940-leds's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move hgafb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move hitfb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move hp680-bl's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move hp-wmi's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move jazzsonic's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move jornada_ssp's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move ks8695_wdt's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move macsonic's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move meth's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move mmci-omap's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move mailbox's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move omap24xxcam's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move mailbox's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move omap_hdq's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move omap-keypad's " Uwe Kleine-König
2009-01-14 5:34 ` Dmitry Torokhov
2009-01-12 22:24 ` [PATCH] move omap_rng's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move omap_wdt's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move orion_nand's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move gen_nand's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move q40fb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move r8a66597_hcd's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move s3c241xfb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sa11x0-fb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move flash's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sb1250-mac's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sgiseeq's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sgivwfb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sgiwd93's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sharpsl-pm's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move sh_mobile_lcdc_fb's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move snd_powermac's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move snirm_53c710's " Uwe Kleine-König
2009-01-12 22:24 ` [PATCH] move spitz-keyboard's " Uwe Kleine-König
2009-01-14 5:34 ` Dmitry Torokhov
2009-01-12 22:24 ` [PATCH] move stk17ta8's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move omap_udc's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move vesafb's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move vfb's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move vga16fb's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move w100fb's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move wm8400-regulator's " Uwe Kleine-König
2009-01-13 9:57 ` Liam Girdwood
2009-01-13 11:39 ` Mark Brown
2009-01-12 22:25 ` [PATCH] move xilinx_spi's " Uwe Kleine-König
2009-01-12 22:25 ` [PATCH] move xtsonic's " Uwe Kleine-König
[not found] ` <20090113031554.GA3671@linux-sh.org>
2009-01-13 6:42 ` platform_driver's probe functions must not be located in .init.text Uwe Kleine-König
2009-07-11 17:05 [PATCH] platform_driver_register: warn if probe is " Greg KH
2009-07-11 20:52 ` [PATCH] move acornfb's probe function to .devinit.text Uwe Kleine-König
2009-07-11 20:52 ` [PATCH] move am79c961's " Uwe Kleine-König
2009-07-11 20:52 ` [PATCH] move arcfb's " Uwe Kleine-König
2009-07-11 20:52 ` [PATCH] move at91_ether's " Uwe Kleine-König
2009-07-11 20:52 ` [PATCH] move cfag12864bfb's " Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca2dc2820901200013y3723785cjb4ca4a0e223f7993@mail.gmail.com \
--to=miguel.ojeda.sandonis@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®