From: Philipp Zabel <p.zabel@pengutronix.de>
To: Anirudh Srinivasan <asrinivasan@oss.tenstorrent.com>
Cc: Drew Fustini <dfustini@oss.tenstorrent.com>,
Joel Stanley <jms@oss.tenstorrent.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
joel@jms.id.au, fustini@kernel.org, mpe@kernel.org,
mpe@oss.tenstorrent.com, npiggin@oss.tenstorrent.com,
agross@kernel.org, agross@oss.tenstorrent.com,
bmasney@redhat.com
Subject: Re: [PATCH v2 2/3] reset: tenstorrent: Add reset controller for Atlantis
Date: Mon, 26 Jan 2026 08:23:19 +0100 [thread overview]
Message-ID: <ca32359d08c642bd68133a8960315a80490f4da7.camel@pengutronix.de> (raw)
In-Reply-To: <CAEev2e_6PePu3omq-Zf1R-8TYikgz9V1cp6cwn0nZ8LaPHaJ2A@mail.gmail.com>
On Fr, 2026-01-23 at 10:15 -0600, Anirudh Srinivasan wrote:
> > > +/* RCPU Reset Register Offsets */
> > > +#define RCPU_BLK_RST_REG 0x001c
> > > +#define LSIO_BLK_RST_REG 0x0020
> > > +#define HSIO_BLK_RST_REG 0x000c
> > > +#define PCIE_SUBS_RST_REG 0x0000
> > > +#define MM_RSTN_REG 0x0014
> >
> > Why not move these into reset-tenstorrent-atlantis.c, they are not part
> > of the interface between clock and reset drivers.
>
> We were considering putting register offsets like this in separate
> header files that are dual licensed. In that case, is it okay to put
> it here?
I see, nothing wrong with that.
regards
Philipp
next prev parent reply other threads:[~2026-01-26 7:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 22:36 [PATCH v2 0/3] Add Tenstorrent Atlantis Clock/Reset Controller Anirudh Srinivasan
2026-01-22 22:36 ` [PATCH v2 1/3] dt-bindings: soc: tenstorrent: Add tenstorrent,atlantis-syscon Anirudh Srinivasan
2026-01-23 7:10 ` Krzysztof Kozlowski
2026-01-24 1:34 ` Anirudh Srinivasan
2026-01-22 22:36 ` [PATCH v2 2/3] reset: tenstorrent: Add reset controller for Atlantis Anirudh Srinivasan
2026-01-23 13:00 ` Philipp Zabel
2026-01-23 16:15 ` Anirudh Srinivasan
2026-01-26 7:23 ` Philipp Zabel [this message]
2026-01-22 22:36 ` [PATCH v2 3/3] clk: tenstorrent: Add Atlantis clock controller driver Anirudh Srinivasan
2026-01-23 7:03 ` kernel test robot
2026-01-23 11:41 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca32359d08c642bd68133a8960315a80490f4da7.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=agross@kernel.org \
--cc=agross@oss.tenstorrent.com \
--cc=asrinivasan@oss.tenstorrent.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@oss.tenstorrent.com \
--cc=fustini@kernel.org \
--cc=jms@oss.tenstorrent.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mpe@kernel.org \
--cc=mpe@oss.tenstorrent.com \
--cc=mturquette@baylibre.com \
--cc=npiggin@oss.tenstorrent.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®