From: Sekhar Nori <nsekhar@ti.com>
To: Alexandre Bailon <abailon@baylibre.com>,
<gregkh@linuxfoundation.org>, <khilman@baylibre.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings
Date: Thu, 27 Oct 2016 17:24:53 +0530 [thread overview]
Message-ID: <ca32fd12-5299-02e8-24c4-501dda4291ab@ti.com> (raw)
In-Reply-To: <7026f012-ffce-cc28-85be-9a5cd26de60f@ti.com>
On Thursday 27 October 2016 05:13 PM, Sekhar Nori wrote:
> On Wednesday 26 October 2016 06:09 PM, Alexandre Bailon wrote:
>> Some macro for DA8xx CFGCHIP are defined in usb-davinci.h,
>> but da8xx-cfgchip.h intend to replace them.
>> The usb-da8xx.c is using both headers, causing redefined symbol warnings.
>
> Looks like this is not true for v4.9-rc2 and so I don't see any warnings
Ah, just noticed that _this_ is the patch that introduces
da8xx-cfgchip.h into usb-da8xx.c. So this is the patch that introduces
the warnings (and fixes them).
I can queue this for v4.10 (with Greg's ack) if you change the
description to make it about cleaning up duplicated defines between
da8xx-cfgchip.h and usb-davinci.h and not talk about "redefined symbol
warnings".
Also, when adding a header file, can you please keep it sorted in
alphabetical order.
Thanks,
Sekhar
next prev parent reply other threads:[~2016-10-27 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 12:39 [PATCH v3] Fix some potential warnings Alexandre Bailon
2016-10-26 12:39 ` [PATCH v3] ARM: davinci: da8xx: Fix some redefined symbol warnings Alexandre Bailon
2016-10-27 11:43 ` Sekhar Nori
2016-10-27 11:54 ` Sekhar Nori [this message]
2016-10-27 14:33 ` Alexandre Bailon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca32fd12-5299-02e8-24c4-501dda4291ab@ti.com \
--to=nsekhar@ti.com \
--cc=abailon@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®